Skip to contentSkip to conversation

drivers/scsi/3w-xxxx.c check_region -> request_region (241p9)

PATCH New Rasmus Andersen 1 participant 1 message Jan 22, 2001

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/scsi/3w-xxxx.c check_region -> request_region (241p9)

(Sorry, forgot lk.)

Hi.

The following patch makes drivers/scsi/3w-xxxx.c use the return code from request_region instead of check_region.

It applies cleanly against ac10 and 241p9.

Comments?

drivers/scsi/3w-xxxx.c +2 -4
@@ -659,8 +659,8 @@
 			continue;
 		}
 
-		/* Make sure that io region isn't already taken */
-		if (check_region((tw_dev->tw_pci_dev->resource[0].start), TW_IO_ADDRESS_RANGE)) {
+		/* Reserve the io address space */
+		if (!request_region((tw_dev->tw_pci_dev->resource[0].start), TW_IO_ADDRESS_RANGE, TW_DEVICE_NAME)) {
 			printk(KERN_WARNING "3w-xxxx: tw_findcards(): Couldn't get io range 0x%lx-0x%lx for card %d.\n", 
 				(tw_dev->tw_pci_dev->resource[0].start), 
 				(tw_dev->tw_pci_dev->resource[0].start) + 
@@ -670,8 +670,6 @@
 			continue;
 		}
     
-		/* Reserve the io address space */
-		request_region((tw_dev->tw_pci_dev->resource[0].start), TW_IO_ADDRESS_RANGE, TW_DEVICE_NAME);
 		error = tw_initialize_units(tw_dev);
 		if (error) {
 			printk(KERN_WARNING "3w-xxxx: tw_findcards(): Couldn't initialize units for card %d.\n", numcards);
Signature · 9 lines
Regards,
        Rasmus([email protected])

"I begin by taking. I shall find scholars later to demonstrate my 
perfect right." - Frederick (II) the Great
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/