Skip to contentSkip to conversation

2.4.1-ac1 UP-APIC/NMI watchdog fixes

PATCH Mikael Pettersson 1 participant 1 message Feb 2, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 7 lines · Mikael Pettersson

This patch (against 2.4.1-ac1) contains the following fixes:
* UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to mpparse.c to permit linking the kernel in pure UP-APIC configs.
* NMI watchdog cleanups: mark setup_apic_nmi_watchdog() as __init, fix the K7 init code to not leave any perfctr MSR uninitialised, avoid having to check CPU type in NMI handler.
(Yes, the merged wrmsr(,,-1) is safe for P6.)

Quoted 2 lines

thanks Mikael! Did you have a chance to test this on a K7? Does UP-APIC-NMI-watchdog code truly 'just work' now on the K7?

I wrote the initial patch using the info I gathered for my performance-monitoring counters driver. Petr Vandrovec tested and debugged it. (Alas, I don't yet have a K7 to play with.)

It seems K7 BIOSen keep the local APIC enabled as opposed to what P6 BIOSen tend to do (at least, Petr's ASUS A7V did), so in a sense, yes "it just works". The clock denoted by the event selector is not perfect (it slows down by a factor of 100 when the CPU is idle), but the NMIs do keep coming in.

I might have been able to whip up something better, if AMD hadn't required an NDA for the K7 BIOS writer's manual. My regard for them is pretty low right now.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/