modversions.h source pollution in 2.4
The following files explicitly include linux/modversions.h. They should not do this, the Makefiles are responsible for automatically including modversions.h. Since modversions.h will disappear in 2.5, consider this advance warning that the offending sources can expect problems.
Maintainers: please fix these sources by removing modversions.h.
arch/ia64/kernel/palinfo.cdrivers/char/amiserial.cdrivers/char/dtlk.cdrivers/char/ip2.cdrivers/char/ip2main.cdrivers/char/rocket.cdrivers/char/serial.cdrivers/md/lvm.cdrivers/net/eepro100.cdrivers/net/epic100.cdrivers/net/starfire.cdrivers/net/wan/lmc/lmc_main.c
The presence of symbols like foo__ver_foo is not a reason to explicitly include modversions.h, see http://www.tux.org/lkml/#s8-8.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Quoted 1 line · Keith Owens
Maintainers: please fix these sources by removing
modversions.h.
[...]
Quoted 2 lines
drivers/net/epic100.cdrivers/net/starfire.c
Fixed.
Jeff
Signature · 7 lines
Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · Keith Owens
The following files explicitly include
linux/modversions.h. They should not do this, the Makefiles are responsible for automatically includingmodversions.h. Sincemodversions.hwill disappear in 2.5, consider this advance warning that the offending sources can expect problems.Maintainers: please fix these sources by removing
modversions.h.
It is not clear from your posting if anything other than removing the "#include <linux/modversions.h>" line is needed... Also, what kernel versions is this needed for? The LVM code uses a common source file for 2.2 and 2.4, so should the #include stay in for 2.2?
Cheers, Andreas
Signature · 7 lines
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/Quoted 3 lines
"#include <
linux/modversions.h>" line is needed... Also, what kernel versions is this needed for? The LVM code uses a common source file for 2.2 and 2.4, so should the #include stay in for 2.2?
It shouldnt there for 2.2 either
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · Andreas Dilger
Quoted 1 line · Keith Owens
Maintainers: please fix these sources by removing
modversions.h.It is not clear from your posting if anything other than removing the "#include <
linux/modversions.h>" line is needed... Also, what kernel versions is this needed for? The LVM code uses a common source file for 2.2 and 2.4, so should the #include stay in for 2.2?
It should be as simple as removing #include <linux/modversions.h>, and it applies to all kernels, back to 2.1.81.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/