Skip to contentSkip to conversation

TCP_NOPUSH on FreeBSD, TCP_CORK on Linux (was: Is sendfile all that sexy?)

DISCUSSION Dan Kegel 4 participants 6 messages Feb 5, 2001 – Feb 6, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dan Kegel

author
#1 lore raw
Quoted 4 lines · Tony Finch
Quoted 2 lines · Tony Finch
Quoted 1 line · Linus Torvalds
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Without proper uncorking (and it really shouldn't be that hard to add), TCP_NOPUSH simply can't be used in the generic sense.

It was easy :-) I've put up a patch for FreeBSD that adds proper uncorking on my homepage <http://apache.org/~fanf/> in the "Stuff" section.

... and it has been committed to -CURRENT, too.

How very cool.

How close is TCP_NOPUSH to behaving identically to TCP_CORK now? If it does behave identically, it might be time to standardize the symbolic name for this option, to make apps more portable between the two OS's. (It'd be nice to also standardize the numeric value, in the interest of making the ABI's more compatible, too.)

Here are the definitions in the two OS's at the moment:

FreeBSD: netinet/tcp.h (from
http://minnie.cs.adfa.oz.au/FreeBSD-srctree/newsrc/netinet/tcp.h.html#TCP_NOPUSH )

/*
* User-settable options (used with setsockopt).
*/

#define TCP_NODELAY     0x01    /* don't delay send to coalesce packets */
#define TCP_MAXSEG      0x02    /* set maximum segment size */
#define TCP_NOPUSH      0x04    /* don't push last block of write */

Linux: netinet/tcp.h:

/*
* User-settable options (used with setsockopt).
*/

#define TCP_NODELAY 0x01    /* don't delay send to coalesce packets */
#define TCP_MAXSEG  0x02    /* set maximum segment size */
#define TCP_CORK    0x03    /* control sending of partial frames */      

- Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw

Re: TCP_NOPUSH on FreeBSD, TCP_CORK on Linux (was: Is sendfile all that

Quoted 5 lines

How close is TCP_NOPUSH to behaving identically to TCP_CORK now? If it does behave identically, it might be time to standardize the symbolic name for this option, to make apps more portable between the two OS's. (It'd be nice to also standardize the numeric value, in the interest of making the ABI's more compatible, too.)

That one isnt practical because of the way the implementations handle boolean options. BSD uses bitmask based option setting for the basic options and Linus uses switch statements
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

author
#3 lore raw

Re: TCP_NOPUSH on FreeBSD, TCP_CORK on Linux (was: Is sendfile all that

Quoted 10 lines · Alan Cox
Quoted 6 lines

How close is TCP_NOPUSH to behaving identically to TCP_CORK now? If it does behave identically, it might be time to standardize the symbolic name for this option, to make apps more portable between the two OS's. (It'd be nice to also standardize the numeric value, in the interest of making the ABI's more compatible, too.)

That one isnt practical because of the way the implementations handle boolean options. BSD uses bitmask based option setting for the basic options and Linus uses switch statements

OK, well, at least a common symbolic name could be chosen.
- Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw

Re: TCP_NOPUSH on FreeBSD, TCP_CORK on Linux (was: Is sendfile all that

In reply to Alan Cox

Hello!

Quoted 1 line
Quoted 1 line

How close is TCP_NOPUSH to behaving identically to TCP_CORK now?

They have not so much of common.

TCP_NOPUSH enables T/TCP and its presense used to mean that T/TCP is possible on this system. Linux headers cannot even contain TCP_NOPUSH.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw

Re: TCP_NOPUSH on FreeBSD, TCP_CORK on Linux (was: Is sendfile all that

In reply to Dan Kegel
Quoted 9 lines · Alan Cox
Quoted 5 lines

How close is TCP_NOPUSH to behaving identically to TCP_CORK now? If it does behave identically, it might be time to standardize the symbolic name for this option, to make apps more portable between the two OS's. (It'd be nice to also standardize the numeric value, in the interest of making the ABI's more compatible, too.)

That one isnt practical because of the way the implementations handle boolean options. BSD uses bitmask based option setting for the basic options and Linus uses switch statements

No, that's only true for some of the socket-level options. For the TCP options there isn't a direct correspondance between the option number and the number of the flag in the PCB.

Tony.

Signature · 6 lines
f.a.n.finch    [email protected]    [email protected]
"Dead! And yet there he stands!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
#6 lore raw
In reply to a message not in the archive
Quoted 2 lines · Dan Kegel

How close is TCP_NOPUSH to behaving identically to TCP_CORK now?

They are exactly the same.

Quoted 4 lines

If it does behave identically, it might be time to standardize the symbolic name for this option, to make apps more portable between the two OS's. (It'd be nice to also standardize the numeric value, in the interest of making the ABI's more compatible, too.)

I wonder if it's a bit late for that now...

This reminds me to make sure that FreeBSD's Linux emulation supports TCP_CORK properly.

Tony.

Signature · 7 lines
f.a.n.finch    [email protected]    [email protected]
" ``Well, let's go down and find out who's grave it is.''
``How?''  ``By going down and finding out!'' "
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/