Skip to contentSkip to conversation

use correct include dir for build tools

PATCH In review Robert Read 5 participants 6 messages Feb 22, 2001 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use correct include dir for build tools

Linus,

Please apply one line patch to the top level Makefile. This points the build tools at the correct linux include dir.

Makefile Thu Feb 22 12:34:57 2001 renamed from Makefile Wed Feb 21 16:54:15 2001 +1 -1
diff -ru linux/Makefile linux-makefile/Makefile
@@ -16,7 +16,7 @@
 FINDHPATH      = $(HPATH)/asm $(HPATH)/linux $(HPATH)/scsi $(HPATH)/net
 
 HOSTCC         = gcc
-HOSTCFLAGS     = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS     = -I$(HPATH) -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
 
 CROSS_COMPILE  =
 
#1 lore raw
Quoted 2 lines · Robert Read

Please apply one line patch to the top level Makefile. This points the build tools at the correct linux include dir.

Or please don't, it's incorrect.

It breaks cross-compiling, and just generally wrong. If your system won't build without this, it's broken.

Matthew.

#2 lore raw
In reply to Robert Read

Makefile Thu Feb 22 12:34:57 2001 line 19

Quoted 5 lines

FINDHPATH = $(HPATH)/asm $(HPATH)/linux $(HPATH)/scsi $(HPATH)/net

HOSTCC = gcc

Makefile Thu Feb 22 12:34:57 2001 renamed from Makefile Wed Feb 21 16:54:15 2001 +1 -1
-HOSTCFLAGS     = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS     = -I$(HPATH) -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer

That seems odd. Which build tools need to find kernel includes for this kernel not the standard C includes

#3 lore raw
In reply to Robert Read

Ok, my bad, I forgot about cross-compiles. The problem was scripts/split-include.c includes errno.h, which requires linux/errno.h to exist, and I thought it would be better to use the current kernel's version, rather than the system version. I guess not.

robert

Quoted 13 lines · Alan Cox

Makefile Thu Feb 22 12:34:57 2001 line 19

Quoted 5 lines

FINDHPATH = $(HPATH)/asm $(HPATH)/linux $(HPATH)/scsi $(HPATH)/net

HOSTCC = gcc

Makefile Thu Feb 22 12:34:57 2001 renamed from Makefile Wed Feb 21 16:54:15 2001 +1 -1
-HOSTCFLAGS     = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS     = -I$(HPATH) -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer

That seems odd. Which build tools need to find kernel includes for this kernel not the standard C includes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#4 lore raw
In reply to Robert Read
Quoted 4 lines · Robert Read

Ok, my bad, I forgot about cross-compiles. The problem was scripts/split-include.c includes errno.h, which requires linux/errno.h to exist, and I thought it would be better to use the current kernel's version, rather than the system version. I guess not.

Oh no. Definitely not.

Linus went on a tirade not too long ago about that. You can search the kernel archives for the details and long heated threads. But it comes down to this:

For user space compiling, the kernel include files should be those that libc was built against.

For kernel space compiling, the kernel include files should be those that the components will link against (static or modules).

So, theoretically, a package that has both components should take care to do the proper includes. But that's it.

(libc does usually take care to be able to build against a later kernel version than you're running on, and determine at run time what features may or may not be there, so one could have a 2.4.2 kernel handy to build libc against while still running a 2.2.18 kernel. Theoretically.)

mrc

Signature · 4 lines
       Mike Castle       Life is like a clock:  You can work constantly
  [email protected]  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen
#5 lore raw
In reply to Robert Read
Quoted 4 lines · Mike Castle

(libc does usually take care to be able to build against a later kernel version than you're running on, and determine at run time what features may or may not be there, so one could have a 2.4.2 kernel handy to build libc against while still running a 2.2.18 kernel. Theoretically.)

Red Hat did that for glibc-2.1.9 and glibc-2.2 in RHL-7.0. Hundreds have complaind about /usr/include/linux not being a sym link to /usr/src/linux/include/linux. The kernel headers for glibc are form a pre 2.4.0 kernel and should probably be updated along with a new glibc built against the new headers.
I've had no problems with it so far, been running since the pinstripe beta release.

-Thomas