cpu_has_fxsr or cpu_has_xmm?
I've been looking at various -ac patches for the last couple of weeks and have been wondering why only this piece of difference still remains between Linus' 2.4.2 and Alan's -ac2. All the other diffs in i387.c from 2.4.1-ac2 seem to have been merged into Linus tree at around 2.4.2-pre1. Could anybody explain it for me please?
arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 renamed from arch/i386/kernel/i387.c Thu Feb 22 09:05:35 2001 +1 -1
@@ -179,7 +179,7 @@ unsigned short get_fpu_mxcsr( struct task_struct *tsk ) { - if ( cpu_has_fxsr ) { + if ( cpu_has_xmm ) { return tsk->thread.i387.fxsave.mxcsr; } else { return 0x1f80;
------------------------------------------------------------
--== Sent via Deja.com ==--
http://www.deja.com/
Followup to: <[email protected]> By author: "Quim K Holland" <[email protected]> In newsgroup: linux.dev.kernel
Quoted 11 lines
I've been looking at various -ac patches for the last couple of weeks and have been wondering why only this piece of difference still remains between Linus' 2.4.2 and Alan's -ac2. All the other diffs in
i387.cfrom 2.4.1-ac2 seem to have been merged into Linus tree at around 2.4.2-pre1. Could anybody explain it for me please?
arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 line 185
Quoted 8 lines
arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 renamed from arch/i386/kernel/i387.c Thu Feb 22 09:05:35 2001 +1
-1@@ -179,7 +179,7 @@ unsigned short get_fpu_mxcsr( struct task_struct *tsk ) { - if ( cpu_has_fxsr ) { + if ( cpu_has_xmm ) { return tsk->thread.i387.fxsave.mxcsr; } else { return 0x1f80;
IMO, XMM is correct here; FXSR is incorrect. Linus?
-hpa
Signature · 3 lines
<[email protected]> at work, <[email protected]> in private! "Unix gives you enough rope to shoot yourself in the foot." http://www.zytor.com/~hpa/puzzle.txt
Quoted 15 lines · H. Peter Anvin
Followup to: <[email protected]> By author: "Quim K Holland" <[email protected]> In newsgroup: linux.dev.kernelQuoted 11 lines
I've been looking at various -ac patches for the last couple of weeks and have been wondering why only this piece of difference still remains between Linus' 2.4.2 and Alan's -ac2. All the other diffs in
i387.cfrom 2.4.1-ac2 seem to have been merged into Linus tree at around 2.4.2-pre1. Could anybody explain it for me please?arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 renamed from arch/i386/kernel/i387.c Thu Feb 22 09:05:35 2001 +0
-0@@ -179,7 +179,7 @@
Quoted 10 lines
arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 line 185
Quoted 8 lines
arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001 renamed from arch/i386/kernel/i387.c Thu Feb 22 09:05:35 2001 +1
-1unsigned short get_fpu_mxcsr( struct task_struct *tsk ) { - if ( cpu_has_fxsr ) { + if ( cpu_has_xmm ) { return tsk->thread.i387.fxsave.mxcsr; } else { return 0x1f80;IMO, XMM is correct here; FXSR is incorrect. Linus?
I sent Linus a patch that changed that to xmm (along with the same in another place or two, where needed). Linus I guess dropped that one line out of the patch while Alan kept it. That's the reason for the difference. As to the correctness, the mxcsr register really only exists if you have xmm, so the xmm is the correct test. However, the memory location in the fxsr structure was reserved by the time the fxsr was put together, so the worst this does is give an undefined mxcsr value on machines where mxcsr doesn't exist, which is why I didn't yell too loudly when Linus dropped that line out. User space programmers should be checking for xmm capability themselves before ever paying attention to mxcsr anyway, so it's not an end of the world error.
Signature · 3 lines
Doug Ledford <[email protected]> http://people.redhat.com/dledford Please check my web site for aic7xxx updates/answers before e-mailing me about problems