Skip to contentSkip to conversation

possible bug x86 2.4.2 SMP in IP receive stack

DISCUSSION [email protected] 1 participant 1 message Feb 27, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hello!

Quoted 1 line
Feb 23 12:42:30 rcc2 kernel: Warning: kfree_skb passed an skb still on a list (from c01f58dc).

BTW, that's didactic example of bug which results in similar behaviour.

Alexey

Quoted 35 lines

From: [email protected] (Andrew Morton)
Subject: Re: Failed assertion
Date: 27 Feb 2001 04:15:01 +0300

Quoted 7 lines · David S. Miller
Quoted 2 lines · Ralf Baechle

No backtrace, the machine did continue as you'd suspect after a print. The machine is a dual CPU Origin 200 with an IOC3 NIC.

What is your current kernel based upon, some older 2.4.x or even 2.3.x variant? Or is it sync'd to current?

Could this be a driver problem? This code:

            netif_rx(skb);

            ip->rx_skbs[rx_entry] = NULL;   /* Poison  */

            new_skb = ioc3_alloc_skb(RX_BUF_ALLOC_SIZE, GFP_ATOMIC);
            if (!new_skb) {
                /* Ouch, drop packet and just recycle packet
                   to keep the ring filled.  */
                ip->stats.rx_dropped++;
                new_skb = skb;
                goto next;
            }

looks scary. We've passed an skb to the network stack, but we can continue to make it available to the device driver at the same time.

I'd suggest a printk() in there, plus perhaps do the alloc_skb _before_ the netif_rx(). Don't pass the skb to the stack if it is to be recycled.