Skip to contentSkip to conversation

Improved version reporting

PATCH [email protected] 3 participants 3 messages Mar 14, 2001 – Mar 16, 2001

lore
Share & tools
lore
#0 lore raw

From: Riley Williams <[email protected]>

[Yes, I wrote, replying to your mail, just because I happened to notice the incorrect or debatable lines in your patch. Let me cc the Changes maintainer - maybe Chris Ricker.]

     >> -o  util-linux             2.10o                   # fdformat --version
     >> +o  util-linux         #   2.10o        # fdformat --version

> Looking at fdformat to get the util-linux version is perhaps not > the most reliable way - some people have fdformat from elsewhere. > Using mount --version would be better - I am not aware of any > other mount distribution.

RedHat distribute mount separately from util-linux and I wouldnae be surprised if others do the same...

I am not aware of any distribution that ships some version of util-linux, but replaces its mount part by an older version.
I think that even in cases where, because of historical reasons, util-linux is repackaged in several parts, mount --version gives the right answer.

>> +In addition, it is wise to ensure that the following packages are >> +at least at the versions suggested below, although these may not >> +be required, depending on the exact configuration of your system:
>> +
>> +o Console Tools # 0.3.3 # loadkeys -V
>> +o Mount # 2.10e # mount --version

> Concerning mount:
>
> (i) the version mentioned is too old,
> (ii) mount is in util-linux.

Not on RedHat systems.

There is no other source. Some people like to repack but that has no influence on versions.

> Conclusion: the mount line should be deleted entirely. > Concerning Console Tools: maybe kbd-1.05 is uniformly better. > I am not aware of any reason to recommend the use of console-tools.

Neither am I. The ver_linux script has lines for determining the versions for both Console Tools and Kbd but on EVERY system I've tried, including Slackware, RedHat, Debian, Caldera, and SuSE based ones, the line for determining Kbd versiondoesnae work. I've just included the line that worked, and ignored the Kbd one as I can see no point including something that doesnae work.

You are mistaken, as is proved by the reports that contain a kbd line:
a grep on linux-kernel for this Februari shows people with Kbd 0.96, 0.99 and 1.02.

Andries

#1 lore raw
Quoted 2 lines · On Wed, Mar 14, 2001 at 08:29:53PM +0100, [email protected] wrote:

There is no other source. Some people like to repack but that has no influence on versions.

I believe that RedHat don't build mount and util-linux from the same tree. Maybe they do internally, but when you look at the RPMs, they appear separate:

Name: mount
Source RPM: mount-2.10m-6.src.rpm

Name: util-linux
Source RPM: util-linux-2.10m-12.src.rpm

There don't appear to be any explicit dependencies between these two packages either, but they do just happen to have the same version. (I'm looking at the RH7.0 RPMs here).

This of course means that the version of mount may not match the version of util-linux installed on the system.

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

#2 lore raw
In reply to [email protected]

Hi Andries.

Quoted 12 lines

[Yes, I wrote, replying to your mail, just because I happened to notice the incorrect or debatable lines in your patch. Let me cc the Changes maintainer - maybe Chris Ricker.]

Quoted 7 lines
Quoted 7 lines

Review

Quoted 2 lines
(quoted diff) +1 -1
-o  util-linux             2.10o                   # fdformat --version
+o  util-linux         #   2.10o        # fdformat --version

Looking at fdformat to get the util-linux version is perhaps not the most reliable way - some people have fdformat from elsewhere. Using mount --version would be better - I am not aware of any other mount distribution.

Quoted 8 lines
Quoted 2 lines

RedHat distribute mount separately from util-linux and I wouldnae be surprised if others do the same...

I am not aware of any distribution that ships some version of util-linux, but replaces its mount part by an older version. I think that even in cases where, because of historical reasons, util-linux is repackaged in several parts, mount --version gives the right answer.

Neither am I - but, according to comments from RedHat a while back, they repackage mount separately because they provide a NEWER version of mount than is in the util-linux package. This will ALSO result in mount --version giving the wrong answer...

Quoted 14 lines
Quoted 13 lines
Quoted 10 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+In addition, it is wise to ensure that the following packages are
+at least at the versions suggested below, although these may not
+be required, depending on the exact configuration of your system:
+
+o  Console Tools      #   0.3.3        # loadkeys -V
+o  Mount              #   2.10e        # mount --version

Concerning mount:

(i) the version mentioned is too old,

As stated in my original post, I've no idea what the correct version should be as it's not documented anywhere I can find.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

(ii) mount is in util-linux.

Not on RedHat systems.

There is no other source. Some people like to repack but that has no influence on versions.

Unless one can guarantee that the util-linux and mount packages are the SAME version, mount can't be guaranteed to report the version of the util-linux package installed. RedHat provide a NEWER version of mount to util-linux so that guarantee doesnae exist.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Conclusion: the mount line should be deleted entirely.

Conclusion: Both the mount and util-linux lines are REQUIRED.

Quoted 11 lines
Quoted 10 lines
Quoted 3 lines

Concerning Console Tools: maybe kbd-1.05 is uniformly better. I am not aware of any reason to recommend the use of console-tools.

Neither am I. The ver_linux script has lines for determining the versions for both Console Tools and Kbd but on EVERY system I've tried, including Slackware, RedHat, Debian, Caldera, and SuSE based ones, the line for determining Kbd versiondoesnae work. I've just included the line that worked, and ignored the Kbd one as I can see no point including something that doesnae work.

Quoted 3 lines

You are mistaken, as is proved by the reports that contain a kbd
line: a grep on linux-kernel for this Februari shows people with Kbd 0.96, 0.99 and 1.02.

{Shrug} Please explain why I was unable to get ver_linux to report a kbd line on ANY of the systems I tried, including systems with it definately installed. I tried it out manually on several such systems, and ALL reported the SAME error message to the loadkeys -h command used in scripts/ver_linux which is:

Q> $ loadkeys -h 2>&1 > x
Q> Usage: loadkeys [option...] [mapfile...]
Q> valid options are:

 Q>   -c --clearcompose clear kernel compose table
 Q>   -d --default      load default keymap file
 Q>   -m --mktable      output a "defkeymap.c" to stdout
 Q>   -s --clearstrings clear kernel string table
 Q>   -q --quiet        be silent
 Q>   -v --verbose      report the changes
 Q>   -v --verbose      report more changes
 Q>   -h --help         display this help text and exit
 Q>   -V --version      display version information and exit

Q> $

Also, please advise where the version number is in that text...

Best wishes from Riley.