Skip to contentSkip to conversation

magic device renumbering was -- Re: Linux 2.4.2ac20

util-linux [email protected] 4 participants 4 messages Mar 15, 2001 – Mar 16, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

I've implemented a patch for util-linux-2.11a which adds LABEL support to mkswap(8) and swapon/swapoff(8).

Yes, maybe a reasonable idea.

But I would prefer a somewhat more ambitious approach.

My first thought was: why label individual swap partitions? I almost never want to distinguish swap partitions, and just do "swapon -a". In case one wants to guard against changing device names, why not add an option -A so that "swapon -A" does swapon on each partition with a swap signature?

However, that would greatly increase the risk that exists already
today: someone has a swap partition, and does mkfs.foo, and it so happens that foofs does not use the sector with the swapsignature. Now this foofs partition has a swap signature, but we would be very unhappy if it were used as swap space.

The real problem is that our disks usually do not have a volume label. Outside of all file systems.
The "signatures" that we rely on today are located in different places, so that a filesystem can have several valid signatures at the same time. And we first know where to look when we know the type already.

Design a Linux partition table format, where a partition descriptor has fields start, end, fstype, fslabel, and the whole disk has a vollabel. Put it in sector 0-N for an all-Linux disk, and in sectors pointed at by a classical DOS-type partition table entry when the disk is shared.

(Maybe I already did that once - it sounds so familiar now that I write this. Then why was it not pursued? Maybe LVM already does these things?)

Andries

#1 lore raw
Quoted 4 lines · On Fri, 16 Mar 2001 [email protected] wrote:

Design a Linux partition table format, where a partition descriptor has fields start, end, fstype, fslabel, and the whole disk has a vollabel. Put it in sector 0-N for an all-Linux disk, and in sectors pointed at by a classical DOS-type partition table entry when the disk is shared.

Yes, but for $DEITY sake, let's make it text. Something along the lines of Linux partition table\n(START,LENGTH,TYPE(,LABEL)?n)*End\0
START: NUMBER
LENGTH: NUMBER
TYPE: [^,\n\0]+
LABEL: [^\n\0]+
NUMBER: <see strtoul(3)>

Will make life much simpler when one needs to recover the bloody thing...

#2 lore raw
In reply to [email protected]
Quoted 11 lines · Andries
Quoted 2 lines

I've implemented a patch for util-linux-2.11a which adds LABEL support to mkswap(8) and swapon/swapoff(8).

But I would prefer a somewhat more ambitious approach.

My first thought was: why label individual swap partitions? I almost never want to distinguish swap partitions, and just do "swapon -a". In case one wants to guard against changing device names, why not add an option -A so that "swapon -A" does swapon on each partition with a swap signature?

Quoted 5 lines

However, that would greatly increase the risk that exists already
today: someone has a swap partition, and does mkfs.foo, and it so happens that foofs does not use the sector with the swapsignature. Now this foofs partition has a swap signature, but we would be very unhappy if it were used as swap space.

I think the LABEL is a good intermediate step for people not using LVM. It basically allows your /etc/fstab to not have _any_ device names in it. I'm not sure I would be happy with auto-mounting swap partitions, especially because this would overwrite any data in the partition. Bad.

Quoted 6 lines

The real problem is that our disks usually do not have a volume label. Outside of all file systems.
The "signatures" that we rely on today are located in different places, so that a filesystem can have several valid signatures at the same time. And we first know where to look when we know the type already.

Quoted 7 lines

Design a Linux partition table format, where a partition descriptor has fields start, end, fstype, fslabel, and the whole disk has a vollabel. Put it in sector 0-N for an all-Linux disk, and in sectors pointed at by a classical DOS-type partition table entry when the disk is shared.

(Maybe I already did that once - it sounds so familiar now that I write this. Then why was it not pursued? Maybe LVM already does these things?)

LVM will handle the disk and "partition" naming and size issues.

It does NOT currently handle the fstype names, but this _could_ be determined via magic numbers, as now. In the "(struct dentry *)->vfsmnt" thread, I was trying to work out a way to get mountpoint information for LVM. In the end, I think I will store most of the /etc/fstab line into a field in the LV header, so it is easily retrievable. This would also include the fstype, and mount/dump/fsck options. It would _not_ store the device name.

The proposed solution would be to have mount(8) write the mount info to the disk (for logical volumes only, of course) at mount time. I suppose the fs type, options, mountpoint could come from either /etc/fstab or from the command-line, since mount(8) is already parsing all of this info.

Cheers, Andreas

Signature · 3 lines
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert
#3 lore raw
Quoted 12 lines · Andreas Dilger
Quoted 11 lines · Andries
Quoted 2 lines

I've implemented a patch for util-linux-2.11a which adds LABEL support to mkswap(8) and swapon/swapoff(8).

But I would prefer a somewhat more ambitious approach.

My first thought was: why label individual swap partitions? I almost never want to distinguish swap partitions, and just do "swapon -a". In case one wants to guard against changing device names, why not add an option -A so that "swapon -A" does swapon on each partition with a swap signature?

Quoted 8 lines
Quoted 5 lines

However, that would greatly increase the risk that exists already
today: someone has a swap partition, and does mkfs.foo, and it so happens that foofs does not use the sector with the swapsignature. Now this foofs partition has a swap signature, but we would be very unhappy if it were used as swap space.

I think the LABEL is a good intermediate step for people not using LVM. It basically allows your /etc/fstab to not have _any_ device names in it.

Exactly. IMO, it doesn't really help having LABEL= on your ext2 partitions in /etc/fstab if you cannot also do the same on swap partitions. My LABEL= patch for mkswap/swapon may not be as sexy as a brand new partition table format [which arguably is the better solution in the long run], but it does provide a useful improvement NOW with minimal implementation cost and full compatibility with existing 2.2/2.4 kernels.

Quoted 2 lines

I'm not sure I would be happy with auto-mounting swap partitions, especially because this would overwrite any data in the partition. Bad.

Me too. I can easily add Andries' "swapon -A" to my patch, but I really don't think that semantics should be the default.

Cheers,

/Mikael