Skip to contentSkip to conversation

Keyboard cleanup

parisc-linux Matthew Wilcox 3 participants 3 messages Mar 22, 2001 – Mar 26, 2001

lore
Share & tools
lore
#0 lore raw

we're getting a big pile of warnings:

hp_keyb.c:282: warning: (near initialization for `high_keys')

and it seems to be because the array we're initialising is of size 0 (128 - SC_LIM). the following patch seems to DTRT, but i would appreciate someone who has a (non-HIL) keyboard testing it and confirming it works.

Index: drivers/char/hp_keyb.c
===================================================================
RCS file: /home/cvs/parisc/linux/drivers/char/hp_keyb.c,v retrieving revision 1.3

hp_keyb.c +1 -1
diff -u -p -r1.3 hp_keyb.c
@@ -246,7 +246,7 @@ unsigned char hp_ps2kbd_sysrq_xlate[128]
  * they needed not before. It does not matter that there are duplicates, as
  * long as no duplication occurs for any single keyboard.
  */
-#define SC_LIM 128
+#define SC_LIM 59
 
 #define FOCUS_PF1 85           /* actual code! */
 #define FOCUS_PF2 89
#1 lore raw
Quoted 3 lines · Matthew Wilcox

and it seems to be because the array we're initialising is of size 0 (128 - SC_LIM). the following patch seems to DTRT, but i would appreciate someone who has a (non-HIL) keyboard testing it and confirming it works.

If no-one comes back to me by next weekend and says `no it doesn't work', i'm going to commit this anyway and be unsympathetic if it has broken.

Signature · 1 line
Revolutions do not require corporate support.
#2 lore raw

This patch worked fine for me on my 712/80 with a ps2 keyboard.

- Ryan

Quoted 17 lines · Matthew Wilcox
Quoted 3 lines · Matthew Wilcox

and it seems to be because the array we're initialising is of size 0 (128 - SC_LIM). the following patch seems to DTRT, but i would appreciate someone who has a (non-HIL) keyboard testing it and confirming it works.

If no-one comes back to me by next weekend and says `no it doesn't work', i'm going to commit this anyway and be unsympathetic if it has broken.

Signature · 7 lines
Revolutions do not require corporate support.


_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/cgi-bin/mailman/listinfo/parisc-linux