Skip to contentSkip to conversation

Underscore in rivafb

PATCH Stuart McFadden 2 participants 2 messages Apr 4, 2001 Framebuffer layer

lore
Share & tools
lore

Stuart McFadden

author
#0 lore raw

Hi,
The flashing block in rivafb was annoying me, so here is a diff (against
vanilla 2.4.3 ) of a quick hack in case anyone else was having the same problem.

Stuarty,

drivers/video/riva/fbdev.c +9 -6
diff -urN linux.pure/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
@@ -534,7 +534,7 @@
 	struct riva_cursor *c = rinfo->cursor;
 	int i, j, idx;
 
-	if (c) {
+  	if (c) {
 		if (width <= 0 || height <= 0) {
 			width = 8;
 			height = 16;

@@ -547,13 +547,16 @@
 		
 		idx = 0;
 
-		for (i = 0; i < height; i++) {
-			for (j = 0; j < width; j++,idx++)
-				c->image[idx] = CURSOR_COLOR;
-			for (j = width; j < MAX_CURS; j++,idx++)
+		for (i = MAX_CURS; i > height + 2; i--) 
+			for (j = 0; j < MAX_CURS; j++,idx++)
 				c->image[idx] = TRANSPARENT_COLOR;
+		for (i = height + 2; i > height; i--) {
+			for (j = 0; j < width; j++,idx++)
+			        c->image[idx] = CURSOR_COLOR;
+			for (j = width; j < MAX_CURS;j++,idx++)
+			        c->image[idx] = TRANSPARENT_COLOR;
 		}
-		for (i = height; i < MAX_CURS; i++)
+		for (i = height; i > 0; i--) 
 			for (j = 0; j < MAX_CURS; j++,idx++)
 				c->image[idx] = TRANSPARENT_COLOR;
 	}
Signature · 3 lines
Start the day with a smile.  After that you can be your nasty old self again.
 - - - - - - - - - - - - - - - - - - - - -  
Stuarty McFadden [email protected]
#1 lore raw
Quoted 4 lines · Stuart McFadden

Hi,
The flashing block in rivafb was annoying me, so here is a diff (against
vanilla 2.4.3 ) of a quick hack in case anyone else was having the same problem.

Get a look at drivers/video/matrox/matroxfb_misc:matroxfb_createcursorshape, and its callers, matroxfb_*_createcursor. If you'll use conp->vc_cursor_type, standard
escape sequences for disabling cursor and for shape selection will work on
riva then...
Petr Vandrovec [email protected]