Skip to contentSkip to conversation

NWFS broken on 2.4.3 -- someone removed WRITERAW

DISCUSSION Jeff V. Merkey 2 participants 3 messages Apr 23, 2001

lore
Share & tools
lore
#0 lore raw

Hey guys,

Whomever removed WRITERAW has broken NWFS. WRITE requests call _refile_buffer() after the I/O request and take my locally created buffer heads and munge them back into the linux buffer cache, causing massive memory corruption in the system. These buffers don't belong in Linus' buffer cache, they are owned by my LRU and ll_rw_block should not be blindly filing them back into the buffer cache.

Please put something back in to allow me to write without the buffer heads always getting filed into Linus' buffer cache. This has broken NWFS on 2.4.3 and above.

As for using Linus' buffer cache, until you put in the ability to create logical block mapping instead of physical, I will not be able to use it. Hopefully, this will make it in 2.5. I have some folks trying to use this with 2.4.3 and they are dead in the water until this gets addressed.

Thanks

Jeff

#1 lore raw
Quoted 11 lines · Jeff V. Merkey

Hey guys,

Whomever removed WRITERAW has broken NWFS. WRITE requests call _refile_buffer() after the I/O request and take my locally created buffer heads and munge them back into the linux buffer cache, causing massive memory corruption in the system. These buffers don't belong in Linus' buffer cache, they are owned by my LRU and ll_rw_block should not be blindly filing them back into the buffer cache.

Quoted 3 lines

Please put something back in to allow me to write without the buffer heads always getting filed into Linus' buffer cache. This has broken NWFS on 2.4.3 and above.

	bh->b_end_io = my_end_io_handler;
	submit_bh(WRITE, bh);

Be a happy camper.

Signature · 1 line
Jens Axboe
#2 lore raw
In reply to Jeff V. Merkey
Quoted 12 lines · Jens Axboe
Quoted 11 lines · Jeff V. Merkey

Hey guys,

Whomever removed WRITERAW has broken NWFS. WRITE requests call _refile_buffer() after the I/O request and take my locally created buffer heads and munge them back into the linux buffer cache, causing massive memory corruption in the system. These buffers don't belong in Linus' buffer cache, they are owned by my LRU and ll_rw_block should not be blindly filing them back into the buffer cache.

Quoted 6 lines
Quoted 3 lines

Please put something back in to allow me to write without the buffer heads always getting filed into Linus' buffer cache. This has broken NWFS on 2.4.3 and above.

	bh->b_end_io = my_end_io_handler;
	submit_bh(WRITE, bh);

Jens,

Bless you. I'll code the fix, test it, and get it out.

Jeff

Quoted 11 lines

Be a happy camper.

Signature · 7 lines
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/