Skip to contentSkip to conversation

Source code compatibility in Stable series????

DISCUSSION Petr Vandrovec 4 participants 8 messages May 11, 2001

lore
Share & tools
lore
#0 lore raw

linux/skbuff.h Fri May 11 12:12:43 2001 line 32

Quoted 11 lines · Andi Kleen

On Fri, May 11, 2001 at 02:56:35AM -0700, David S. Miller wrote:
I guess it would be possible to add a HAVE_ZEROCOPY to skbuff.h to make it a bit easier for single source drivers.

linux/skbuff.h Fri May 11 12:12:43 2001 renamed from linux/skbuff.h-o Wed May 9 12:36:44 2001 +1 -0
@@ -29,6 +29,7 @@
 #define HAVE_ALLOC_SKB     /* For the drivers to know */
 #define HAVE_ALIGNABLE_SKB /* Ditto 8)        */
 #define SLAB_SKB       /* Slabified skbuffs       */
+#define HAVE_ZEROCOPY      /* Zerocopy stack */ 

When I was updating VMware's vmnet, I decided to use

#ifdef skb_shinfo

This gives you maximal backward compatibility, as all public zerocopy patches contain this macro. Only thing is that Dave has to remember that when he turns skb_shinfo into inline function, an identity #define have to be added.

Just my opinion - as you cannot add HAVE_ZEROCOPY to all already existing and installed kernels.
Petr Vandrovec [email protected]

#1 lore raw
Quoted 3 lines · Petr Vandrovec

When I was updating VMware's vmnet, I decided to use

#ifdef skb_shinfo

Yes I forgot that RedHat already shipped it :-(

Quoted 4 lines

This gives you maximal backward compatibility, as all public zerocopy patches contain this macro. Only thing is that Dave has to remember that when he turns skb_shinfo into inline function, an identity #define have to be added.

No such guarantee for binary only software ;)

-Andi

#2 lore raw
Quoted 5 lines · Andi Kleen
Quoted 3 lines · Petr Vandrovec

When I was updating VMware's vmnet, I decided to use

#ifdef skb_shinfo

Quoted 8 lines

Yes I forgot that RedHat already shipped it :-(

Quoted 4 lines

This gives you maximal backward compatibility, as all public zerocopy patches contain this macro. Only thing is that Dave has to remember that when he turns skb_shinfo into inline function, an identity #define have to be added.

No such guarantee for binary only software ;)

Right. I therefore refuse to maintain binary modules for my clients. This usually convinces them to release source code.

But it's always been said that source code compatiblity would be maintained. I'm a bit pissed that people just go about changing public source-level interfaces.

Roger.

Signature · 4 lines
** [email protected] ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots. 
* There are also old, bald pilots. 
#3 lore raw
Quoted 2 lines · Rogier Wolff

But it's always been said that source code compatiblity would be maintained.

"when possible", we've made no such total souce level compat. guarentee. And more such changes are coming, for example the quota bugs can't be fixed without breaking source level compat. for the filesystems.

You may think and argue otherwise, but our ability to break source level compatibility is one of our strengths (see solaris rsh root owned socket bug of yesteryear for one example as to why).

Later,
David S. Miller
[email protected]

#4 lore raw
In reply to Andi Kleen
Quoted 3 lines · Rogier Wolff

But it's always been said that source code compatiblity would be maintained. I'm a bit pissed that people just go about changing public source-level interfaces.

2.4.4 is basically like 2.5.0 as far as networking is concerned, it includes major fundamental changes to the stack.

-Andi

#5 lore raw
Quoted 7 lines · Andi Kleen
Quoted 3 lines · Rogier Wolff

But it's always been said that source code compatiblity would be maintained. I'm a bit pissed that people just go about changing public source-level interfaces.

2.4.4 is basically like 2.5.0 as far as networking is concerned, it includes major fundamental changes to the stack.

yeah. I noticed. I'm supposed to be happy about this?

I'll manage, and I'll "deal with it", but not before I've told you that I'm not happy about it.

Roger.

Signature · 4 lines
** [email protected] ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots. 
* There are also old, bald pilots. 
#7 lore raw
In reply to Petr Vandrovec
Quoted 3 lines · Petr Vandrovec

When I was updating VMware's vmnet, I decided to use

#ifdef skb_shinfo

No, don't use that, use MAX_SKB_FRAGS like the drivers do. I guarentee to preserve that, whereas I reserve the right to change the skb_shinfo implementation however I like.

Later,
David S. Miller
[email protected]