Skip to contentSkip to conversation

Bad udelay usage in drivers/net/aironet4500_card.c

DISCUSSION H . J . Lu 2 participants 2 messages May 15, 2001 – May 19, 2001

lore
Share & tools
lore

H . J . Lu

author
#0 lore raw

In 2.4.4, drivers/net/aironet4500_card.c has

# grep udelay linux/drivers/net/aironet4500_card.c
                udelay(1000);
        udelay(100);
                udelay(10);
        udelay(100000);
        udelay(200000);
        udelay(250000);
        udelay(10000);
        udelay(10000);
        udelay(1000);
        udelay(1000);
        udelay(10000);

But on ia32, you cannot use more than 20000 for udelay (). You will get undefined symbol, __bad_udelay.

H.J.

#1 lore raw
Quoted 10 lines · H . J . Lu

In 2.4.4, drivers/net/aironet4500_card.c has

        udelay(100000);
        udelay(200000);
        udelay(250000);

But on ia32, you cannot use more than 20000 for udelay (). You will get undefined symbol, __bad_udelay.

mv driver.c driver.c~
sed 's/udelay\( *\)(\([1-9][0-9]*\)000)/mdelay\1(\2)/' <driver.c~>driver.c

...keeps foo(...) or foo (...) as per original author's taste.
^ ^
Paul.