Skip to contentSkip to conversation

8139too on 2.2.19 doesn't close file descriptors

DISCUSSION Santiago Garcia Mantinan 3 participants 4 messages May 17, 2001 – May 18, 2001

lore
Share & tools
lore
#0 lore raw

Hi!

I was tracking down a problem with Debian installation freezing when doing the ifconfig of the 8139too driver on 2.2.19 kernel, and found that this was caused by 8139too for 2.2.19 not closing it's file descriptors.

The original code by Jeff for the 2.4 series is ok, and searching for the cause of the problem I have found a difference in the way rtl8139_thread exits on both versions:

2.2 version:

        up (&tp->thr_exited);
        return 0;

2.4 version:

        up_and_exit (&tp->thr_exited, 0);

I think the problem must be there, not doing the do_exit on the 2.2 version, but I may be wrong, can anybody look this up?

Thanks in advance!

Regards...

Signature · 1 line
Manty/BestiaTester -> http://manty.net
#1 lore raw
Quoted 12 lines · Santiago Garcia Mantinan

Hi!

I was tracking down a problem with Debian installation freezing when doing the ifconfig of the 8139too driver on 2.2.19 kernel, and found that this was caused by 8139too for 2.2.19 not closing it's file descriptors.

The original code by Jeff for the 2.4 series is ok, and searching for the cause of the problem I have found a difference in the way rtl8139_thread exits on both versions:

2.2 version:

Quoted 8 lines
        up (&tp->thr_exited);
        return 0;

2.4 version:

        up_and_exit (&tp->thr_exited, 0);

I think the problem must be there, not doing the do_exit on the 2.2 version, but I may be wrong, can anybody look this up?

No, that's OK.

In 2.2, daemonize() does *not* do exit_files(). In 2.4 it does. I wonder why?

Try putting an

	exit_files(current);

at the start of rtl8139_thread()

#2 lore raw
In reply to Santiago Garcia Mantinan
Quoted 1 line

No, that's OK.

I realised about this when I inserted up_and_exit on 2.2 and still it did the same :-)

Quoted 3 lines

Try putting an

	exit_files(current);

at the start of rtl8139_thread()

Yes, this seems to solve the problem, thanks!

Regards...

Signature · 1 line
Manty/BestiaTester -> http://manty.net
#3 lore raw
In reply to Santiago Garcia Mantinan

Hi,

Quoted 11 lines · you

Hi!

I was tracking down a problem with Debian installation freezing when doing the ifconfig of the 8139too driver on 2.2.19 kernel, and found that this was caused by 8139too for 2.2.19 not closing it's file descriptors.

The original code by Jeff for the 2.4 series is ok, and searching for the cause of the problem I have found a difference in the way rtl8139_thread exits on both versions:

2.2 version:

Quoted 8 lines
        up (&tp->thr_exited);
        return 0;

2.4 version:

        up_and_exit (&tp->thr_exited, 0);

I think the problem must be there, not doing the do_exit on the 2.2 version, but I may be wrong, can anybody look this up?

I added the exit_files(current) to the version in my source repository. Will be contained in the next releases. Thanks!
Btw.: CC'ing me was a good idea, I'm not on linux-kernel, only on linux-net due to mail volume.

-- Jens