Skip to contentSkip to conversation

PATCH for dl2k driver

PATCH Konstantin Volckov 2 participants 2 messages Jul 10, 2001 Network drivers

lore
Share & tools
lore
#0 lore raw

Hi!

There is a mistake in dl2k.c network driver added in 2.4.6-ac2.

Without this patch gcc-2.95.3 produces a broken symbol __ucmpdi2, while gcc-2.96 works ok.

Signature · 2 lines
Good luck,
Konstantin
drivers/net/dl2k.c renamed from drivers/net/dl2k.c_old +2 -2
@@ -559,7 +559,7 @@
 			}
 		}
 		/* Free used tx skbuffs */
-		for (; np->cur_tx - np->old_tx > 0; np->old_tx++) {
+		for (; np->cur_tx > np->old_tx; np->old_tx++) {
 			int entry = np->old_tx % TX_RING_SIZE;
 			if (!(np->tx_ring[entry].status & TFDDone))
 				break;
@@ -710,7 +710,7 @@
 	}
 
 	/* Re-allocate skbuffs to fill the descriptor ring */
-	for (; np->cur_rx - np->old_rx > 0; np->old_rx++) {
+	for (; np->cur_rx > np->old_rx; np->old_rx++) {
 		struct sk_buff *skb;
 		entry = np->old_rx % RX_RING_SIZE;
 		/* Dropped packets don't need to re-allocate */
#1 lore raw
Quoted 1 line · Konstantin Volckov

There is a mistake in dl2k.c network driver added in 2.4.6-ac2.

I doubt you have hardware for it, so no big deal ;-)

Quoted 2 lines

Without this patch gcc-2.95.3 produces a broken symbol __ucmpdi2, while gcc-2.96 works ok.

Alan please do not apply, there is a better update coming your way, including other bug fixes as well.

Signature · 3 lines
Jeff Garzik      | A recent study has shown that too much soup
Building 1024    | can cause malaise in laboratory mice.
MandrakeSoft     |