Skip to contentSkip to conversation

VIA MVP3 problem is still there...

PATCH Jacek Popławski 2 participants 2 messages Aug 11, 2001

lore
Share & tools
lore
#0 lore raw

Hello
Long, long ago, in 2.4.3-pre - appeared fixup for VIA chipsets, however, fixups for VIA MVP3 was unnecessary, and even slowed down system. It's already fixed in -ac, but this broken fixup is still in 2.4.8 kernel. It affects most of K6-2/K6-3 users. There are stable kernels in distributions, not -ac, so IMHO it will be good to fix that problem at last - and it's only two lines of code:

arch/i386/kernel/pci-pc.c Sat Aug 11 16:20:04 2001 renamed from arch/i386/kernel/pci-pc.c Sat Aug 11 16:19:30 2001 +0 -2
@@ -994,8 +994,6 @@
        { PCI_FIXUP_HEADER,     PCI_ANY_ID,             PCI_ANY_ID,                     pci_fixup_ide_bases },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_SI,       PCI_DEVICE_ID_SI_5597,          pci_fixup_latency },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_SI,       PCI_DEVICE_ID_SI_5598,          pci_fixup_latency },
-       { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_VIA,      PCI_DEVICE_ID_VIA_82C691,       pci_fixup_via691 },
-       { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_VIA,      PCI_DEVICE_ID_VIA_82C598_1,     pci_fixup_via691_2 },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_INTEL,    PCI_DEVICE_ID_INTEL_82371AB_3,  pci_fixup_piix4_acpi },
        { 0 }
 };
#1 lore raw
Quoted 3 lines

in -ac, but this broken fixup is still in 2.4.8 kernel. It affects most of K6-2/K6-3 users. There are stable kernels in distributions, not -ac, so IMHO it will be good to fix that problem at last - and it's only two lines of code:

Actually most distro kernels have the fix and are -ac based. However you are right Linus - I'd forgotten this was still in your tree:

Quoted 11 lines
arch/i386/kernel/pci-pc.c Sat Aug 11 16:20:04 2001 renamed from arch/i386/kernel/pci-pc.c Sat Aug 11 16:19:30 2001 +0 -2
@@ -994,8 +994,6 @@
        { PCI_FIXUP_HEADER,     PCI_ANY_ID,             PCI_ANY_ID,                     pci_fixup_ide_bases },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_SI,       PCI_DEVICE_ID_SI_5597,          pci_fixup_latency },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_SI,       PCI_DEVICE_ID_SI_5598,          pci_fixup_latency },
-       { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_VIA,      PCI_DEVICE_ID_VIA_82C691,       pci_fixup_via691 },
-       { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_VIA,      PCI_DEVICE_ID_VIA_82C598_1,     pci_fixup_via691_2 },
        { PCI_FIXUP_HEADER,     PCI_VENDOR_ID_INTEL,    PCI_DEVICE_ID_INTEL_82371AB_3,  pci_fixup_piix4_acpi },
        { 0 }
 };