Skip to contentSkip to conversation

PROBLEM: usb not working with 2.4.8-ac8

DISCUSSION Pete Zaitcev 1 participant 1 message Aug 24, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 1 line

What was you test scenario where you didn't see a completion callback?

The root hub emulation never posts one.

Quoted 11 lines

Review

Quoted 9 lines
(quoted diff) +7 -1
+	if (ret == 0) {				/* N.B. Done, must notify */
+		/* uhci_call_completion(urb); */ /* ->> uhci_destroy_urb_priv */
+		urb->dev = NULL;
+		if (urb->complete)
+			urb->complete(urb);
+	}
 
-	usb_dec_dev_use(urb->dev);
+	usb_dec_dev_use(dev);

What's all of this for? Protecting against an urb->dev race condition?

No race, but we cannot use urb after callback.

-- Pete