Skip to contentSkip to conversation

cleanup in fs/super.c (do_kern_mount())

PATCH [email protected] 2 participants 2 messages Sep 3, 2001

lore
Share & tools
lore
#0 lore raw

From: Alexander Viro <[email protected]>

New helper function: do_kern_mount() (aka. kern_mount() donw right).

+#define MS_NOUSER (1<<31)

But you introduce a new, undocumented, mount flag?

(It seems a pity to take away from the scarce resource "bits in the mount flag" for kernel-internal purposes. Today 14 bits (of the 16) are in use, and as soon as we'll need the 17th, mount will stop adding this 0xC0ED0000 flag, and we'll have 15 or 16 additional bits.

On the other hand, if you think this bit is also useful from user space, then the use should be documented.)

Andries

#1 lore raw
Quoted 7 lines · On Mon, 3 Sep 2001 [email protected] wrote:

From: Alexander Viro <[email protected]>

New helper function: do_kern_mount() (aka. kern_mount() donw right).

+#define MS_NOUSER (1<<31)

But you introduce a new, undocumented, mount flag?

"if you have that in ->s_flags - never attach it to any user-visible mountpoint".

Quoted 2 lines

On the other hand, if you think this bit is also useful from user space, then the use should be documented.)

See above. No, it's not useful for userland ;-) For internal use, OTOH...