Type checking MIN with standard interface
All the silent-cast properties of integer types do not apply to pointers. Therefore...
-----------------------------------------------------------------------------
cub:~> gcc -O2 -Wall min.cmin.c: In function `main':
min.c:19: warning: comparison of distinct pointer types lacks a cast
cub:~> gcc -O2 -Wall kernel-source.c 2>&1 | \
grep "comparison of distinct pointer types lacks a cast" | \
find-and-shoot-programmer:-)
Morten
-----------------------------------------------------------------------------
#include <stdio.h>
#define MIN(x,y) \
({ const typeof(x) _x = x; \
const typeof(y) _y = y; \
\
(void) (&_x == &_y); \
\
_x < _y ? _x : _y; \})
int
main ()
{
/* Good: */
printf ("%d\n", MIN((signed)1, (signed)1));
/* Bad: */
printf ("%d\n", MIN((signed)1, (unsigned)1)); return 0;
}
-----------------------------------------------------------------------------
Quoted 3 lines · Morten Welinder
All the silent-cast properties of integer types do not apply to pointers. Therefore...
Ok, we have a winner. Nice (and more understandable) warning message, along with strict type-checking.
I'm happy. Will do this for 2.4.10-pre5.
Linus