Skip to contentSkip to conversation

3c515 warnings

PATCH New Andres Salomon 1 participant 1 message Sep 16, 2001 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3c515 warnings

I'm not sure what happened to the full_duplex variable in 3c515.c, but it was ignored by the driver anyways. The attached patch removes the MODULE_PARM references to the variable (which would cause a warning to be spewed when you tried to modprobe the driver). Diff'd against 2.4.10-pre9, please apply.

BTW, does anyone actually use this driver? I'm cleaning it up a bit, and possibly (if I have the time) syncing w/ becker's latest; if anyone's interested in testing it out, let me know.

Signature · 2 lines
"Any OS is only as good as its admin, and you obviously suck."
	-- Ian Gulliver, http://orbz.org/mail/mansunix.txt
drivers/net/3c515.c +0 -2
@@ -84,12 +84,10 @@
 MODULE_DESCRIPTION("3Com 3c515 Corkscrew driver");
 MODULE_PARM(debug, "i");
 MODULE_PARM(options, "1-" __MODULE_STRING(8) "i");
-MODULE_PARM(full_duplex, "1-" __MODULE_STRING(8) "i");
 MODULE_PARM(rx_copybreak, "i");
 MODULE_PARM(max_interrupt_work, "i");
 MODULE_PARM_DESC(debug, "3c515 debug level (0-6)");
 MODULE_PARM_DESC(options, "3c515: Bits 0-2: media type, bit 3: full duplex, bit 4: bus mastering");
-MODULE_PARM_DESC(full_duplex, "(ignored)");
 MODULE_PARM_DESC(rx_copybreak, "3c515 copy breakpoint for copy-only-tiny-frames");
 MODULE_PARM_DESC(max_interrupt_work, "3c515 maximum events handled per interrupt");