Skip to contentSkip to conversation

Bug in ipip.c SIOCDELTUNNEL

PATCH In review Taral 2 participants 2 messages Sep 22, 2001 – Sep 25, 2001 Kbuild

lore
Share & tools
lore

Taral

author
#0 lore raw

PATCH 1/1 Bug in ipip.c SIOCDELTUNNEL

Patch is attached. Basically we were always removing "tunl0" even if a different tunnel was specified.

Signature · 4 lines
Taral <[email protected]>
This message is digitally signed. Please PGP encrypt mail to me.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose
ipv4/ipip.c renamed from usr/src/linux-2.4.10-pre14/net/ipv4/ipip.c +1 -0
@@ -758,6 +758,7 @@
 			err = -EPERM;
 			if (t == &ipip_fb_tunnel)
 				goto done;
+			dev = t->dev;
 		}
 		err = unregister_netdevice(dev);
 		break;
#1 lore raw

From: Taral <[email protected]>
Date: Sat, 22 Sep 2001 02:42:41 -0500

Patch is attached. Basically we were always removing "tunl0" even if a different tunnel was specified.

A bug in one tunnel driver is likely to be in all the others :-) I've taken care of that and the patch I am using is below:

ipv4/ipip.c renamed from ipv4/ipip.c.~1~ +2 -1
@@ -1,7 +1,7 @@
 /*
  *	Linux NET3:	IP/IP protocol decoder. 
  *
- *	Version: $Id: ipip.c,v 1.47 2001/09/18 00:36:07 davem Exp $
+ *	Version: $Id: ipip.c,v 1.48 2001/09/25 05:09:53 davem Exp $
  *
  *	Authors:
  *		Sam Lantinga ([email protected])  02/01/95
@@ -758,6 +758,7 @@
 			err = -EPERM;
 			if (t == &ipip_fb_tunnel)
 				goto done;
+			dev = t->dev;
 		}
 		err = unregister_netdevice(dev);
 		break;
ipv4/ip_gre.c renamed from ipv4/ip_gre.c.~1~ +1 -0
@@ -1011,6 +1011,7 @@
 			err = -EPERM;
 			if (t == &ipgre_fb_tunnel)
 				goto done;
+			dev = t->dev;
 		}
 		err = unregister_netdevice(dev);
 		break;
ipv6/sit.c renamed from ipv6/sit.c.~1~ +2 -1
@@ -6,7 +6,7 @@
  *	Pedro Roque		<[email protected]>	
  *	Alexey Kuznetsov	<[email protected]>
  *
- *	$Id: sit.c,v 1.52 2001/09/01 00:31:50 davem Exp $
+ *	$Id: sit.c,v 1.53 2001/09/25 05:09:53 davem Exp $
  *
  *	This program is free software; you can redistribute it and/or
  *      modify it under the terms of the GNU General Public License
@@ -712,6 +712,7 @@
 			err = -EPERM;
 			if (t == &ipip6_fb_tunnel)
 				goto done;
+			dev = t->dev;
 		}
 		err = unregister_netdevice(dev);
 		break;