Skip to contentSkip to conversation

ACPI processor throttling problem in 2.4.10

PATCH Martin Röder 1 participant 1 message Sep 28, 2001 ACPI

lore
Share & tools
lore
#0 lore raw

Hi,

with the 2.4.10 kernel my processor doesn't enter the C2 power state any more. I found the reason to be the state promotion part of pr_power_idle() which actually does no state promotion if bm_control is 0.
As far as I understand, the bm_control flag should only disable the C3 state on machines where busmastering can't be controlled and not disable state changing completely.
The attached patch should correct this problem.

Martin

drivers/acpi/ospm/processor/prpower.c renamed from drivers/acpi/ospm/processor/prpower.c.orig +1 -1
@@ -274,7 +274,7 @@
 			 * by this state's promotion policy, prevents
 			 * promotions from occuring.
 			 */
-			if (bm_control && !(processor->power.bm_activity &
+			if (!bm_control || !(processor->power.bm_activity &
 				c_state->promotion.bm_threshold)) {
 				next_state = c_state->promotion.target_state;
 			}