Skip to contentSkip to conversation

nfsd 2.4.10: unbloat filehandles for export points

PATCH New Chip Salzenberg 1 participant 1 message Oct 2, 2001 NFS server

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd 2.4.10: unbloat filehandles for export points

The otherwise excellent nfsd patches in 2.4.10 accidentally inflated all filehandles for export points to the max size permitted by NFSv3:
64 bytes. This problem isn't just cosmetic; it also breaks SFS
(http://sfs.fs.net). Granted, SFS isn't living quite within the law, but still there's no reason to inflate filehandles.

Thus, this (tested) patch:

fs/nfsd/nfsfh.c renamed from fs/nfsd/nfsfh.c.old +3 -1
@@ -732,6 +732,8 @@
 	struct super_block *sb = dentry->d_inode->i_sb;
 	
-	if (dentry == exp->ex_dentry)
+	if (dentry == exp->ex_dentry) {
+		*maxsize = 0;
 		return 0;
+	}
 
 	if (sb->s_op->dentry_to_fh) {
Signature · 2 lines
Chip Salzenberg               - a.k.a. -              <[email protected]>
 "We have no fuel on board, plus or minus 8 kilograms."  -- NEAR tech