Skip to contentSkip to conversation

2.4.10 and USB Modems...

DISCUSSION Michael H. Warfield 2 participants 3 messages Oct 2, 2001 – Oct 3, 2001

lore
Share & tools
lore
#0 lore raw

Hello,

I just upgraded the kernel on a system which has 4 USB modems
(US Robotics 56K Voice/Fax modems). The modems were recognized and worked under 2.4.6 but under 2.4.10 they are not recognized and I get and error that no driver claims them. Further testing indicates that they are recognized under 2.4.9 but broke sometime between then and 2.4.10.

Here are the syslog USB messages from 2.4.9 (working):

] Oct  2 18:31:06 wittsend kernel: usb-ohci.c: USB OHCI at membase 0xc4846000, IRQ 9
] Oct  2 18:31:06 wittsend kernel: usb-ohci.c: usb-00:02.0, Acer Laboratories Inc. [ALi] M5237 USB
] Oct  2 18:31:06 wittsend kernel: usb.c: new USB bus registered, assigned bus number 1
] Oct  2 18:31:06 wittsend kernel: hub.c: USB hub found
] Oct  2 18:31:06 wittsend kernel: hub.c: 2 ports detected
] Oct  2 18:31:06 wittsend kernel: usb.c: registered new driver acm
] Oct  2 18:31:06 wittsend kernel: acm.c: v0.18:USB Abstract Control Model driver for USB modems and ISDN adapters
] Oct  2 18:31:06 wittsend kernel: hub.c: USB new device connect on bus1/2, assigned device number 2
] Oct  2 18:31:06 wittsend kernel: hub.c: USB hub found
] Oct  2 18:31:06 wittsend kernel: hub.c: 4 ports detected
] Oct  2 18:31:06 wittsend kernel: hub.c: USB new device connect on bus1/2/1, assigned device number 3
] Oct  2 18:31:06 wittsend kernel: ttyACM0: USB ACM device
] Oct  2 18:31:06 wittsend kernel: hub.c: USB new device connect on bus1/2/2, assigned device number 4
] Oct  2 18:31:06 wittsend kernel: ttyACM1: USB ACM device
] Oct  2 18:31:14 wittsend automount[10461]: starting automounter version 3.1.3, path = /mnt/longhall, maptype = file, mapname = /etc/auto.longhall
] Oct  2 18:31:15 wittsend automount[10461]: using kernel protocol version 3
] Oct  2 18:31:06 wittsend kernel: hub.c: USB new device connect on bus1/2/3, assigned device number 5
] Oct  2 18:31:06 wittsend kernel: ttyACM2: USB ACM device
] Oct  2 18:31:06 wittsend kernel: hub.c: USB new device connect on bus1/2/4, assigned device number 6
] Oct  2 18:31:06 wittsend kernel: ttyACM3: USB ACM device

Here are the syslog USB messages from 2.4.10 (not working):

] Oct  2 17:53:25 wittsend kernel: usb-ohci.c: USB OHCI at membase 0xc4845000, IRQ 9
] Oct  2 17:53:25 wittsend kernel: usb-ohci.c: usb-00:02.0, Acer Laboratories Inc. [ALi] M5237 USB
] Oct  2 17:53:25 wittsend kernel: usb.c: new USB bus registered, assigned bus number 1
] Oct  2 17:53:25 wittsend kernel: hub.c: USB hub found
] Oct  2 17:53:25 wittsend kernel: hub.c: 2 ports detected
] Oct  2 17:53:25 wittsend kernel: usb.c: registered new driver acm
] Oct  2 17:53:25 wittsend kernel: acm.c: v0.20:USB Abstract Control Model driver for USB modems and ISDN adapters
] Oct  2 17:53:25 wittsend kernel: hub.c: USB new device connect on bus1/2, assigned device number 2
] Oct  2 17:53:25 wittsend kernel: hub.c: USB hub found
] Oct  2 17:53:25 wittsend kernel: hub.c: 4 ports detected
] Oct  2 17:53:25 wittsend kernel: hub.c: USB new device connect on bus1/2/1, assigned device number 3
] Oct  2 17:53:25 wittsend kernel: usb.c: USB device 3 (vend/prod 0x4c1/0x3021) is not claimed by any active driver.
] Oct  2 17:53:25 wittsend kernel: hub.c: USB new device connect on bus1/2/2, assigned device number 4
] Oct  2 17:53:25 wittsend kernel: usb.c: USB device 4 (vend/prod 0x4c1/0x3021) is not claimed by any active driver.
] Oct  2 17:53:25 wittsend kernel: hub.c: USB new device connect on bus1/2/3, assigned device number 5
] Oct  2 17:53:25 wittsend kernel: usb.c: USB device 5 (vend/prod 0x4c1/0x3021) is not claimed by any active driver.
] Oct  2 17:53:25 wittsend kernel: hub.c: USB new device connect on bus1/2/4, assigned device number 6
] Oct  2 17:53:25 wittsend kernel: usb.c: USB device 6 (vend/prod 0x4c1/0x3021) is not claimed by any active driver.

More information from 2.4.9:

/proc/bus/usb/drivers:

usbdevfs
hub
acm

/proc/bus/usb/devices:

T:  Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#=  1 Spd=12  MxCh= 2
B:  Alloc=103/900 us (11%), #Int=  5, #Iso=  0
D:  Ver= 1.10 Cls=09(hub  ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=0000 ProdID=0000 Rev= 0.00
S:  Product=USB OHCI Root Hub
S:  SerialNumber=c4846000
C:* #Ifs= 1 Cfg#= 1 Atr=40 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=09(hub  ) Sub=00 Prot=00 Driver=hub
E:  Ad=81(I) Atr=03(Int.) MxPS=   2 Ivl=255ms
T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=12  MxCh= 4
D:  Ver= 1.00 Cls=09(hub  ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=0451 ProdID=1446 Rev= 1.00
C:* #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=100mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=09(hub  ) Sub=00 Prot=00 Driver=hub
E:  Ad=81(I) Atr=03(Int.) MxPS=   1 Ivl=255ms
T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=00560500000000A410131E0F0000
C:  #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:* #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=acm
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=01 Cnt=02 Dev#=  4 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=00560500000000A410131D090000
C:  #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:* #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=acm
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#=  5 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=005605000000000E100D1A170000
C:  #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:* #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=acm
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=04 Dev#=  6 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=005605000000000E100D1A020000
C:  #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:* #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=acm
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=acm
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms

lsmod:

Module Size Used by

acm                     5216   4 
usb-ohci               18400   0  (unused)
usbcore                47264   1  [acm usb-ohci]
ipchains               34368   0  (unused)
ip2main                41520   0 

More information from 2.4.10:

/proc/bus/usb/drivers:

usbdevfs
hub
acm

/proc/bus/usb/devices:

T:  Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#=  1 Spd=12  MxCh= 2
B:  Alloc= 11/900 us ( 1%), #Int=  1, #Iso=  0
D:  Ver= 1.10 Cls=09(hub  ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=0000 ProdID=0000 Rev= 0.00
S:  Product=USB OHCI Root Hub
S:  SerialNumber=c4845000
C:* #Ifs= 1 Cfg#= 1 Atr=40 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=09(hub  ) Sub=00 Prot=00 Driver=hub
E:  Ad=81(I) Atr=03(Int.) MxPS=   2 Ivl=255ms
T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=12  MxCh= 4
D:  Ver= 1.00 Cls=09(hub  ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=0451 ProdID=1446 Rev= 1.00
C:* #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr=100mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=09(hub  ) Sub=00 Prot=00 Driver=hub
E:  Ad=81(I) Atr=03(Int.) MxPS=   1 Ivl=255ms
T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=00560500000000A410131E0F0000
C:* #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:  #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=(none)
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=01 Cnt=02 Dev#=  4 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=00560500000000A410131D090000
C:* #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:  #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=(none)
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#=  5 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=005605000000000E100D1A170000
C:* #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:  #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=(none)
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=04 Dev#=  6 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=005605000000000E100D1A020000
C:* #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:  #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=(none)
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms

lsmod:

Module Size Used by

acm                     5024   0  (unused)
usb-ohci               17632   0  (unused)
usbcore                46176   1  [acm usb-ohci]
ipchains               29632   0 
ip2main                41168   0 

Mike

Signature · 4 lines
 Michael H. Warfield    |  (770) 985-6132   |  [email protected]
  (The Mad Wizard)      |  (678) 463-0932   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!
#1 lore raw
Quoted 19 lines

From: "Michael H. Warfield" <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Date: Tue, 2 Oct 2001 18:47:57 -0400

I just upgraded the kernel on a system which has 4 USB modems
(US Robotics 56K Voice/Fax modems). The modems were recognized and worked under 2.4.6 but under 2.4.10 they are not recognized and I get and error that no driver claims them. [...]

T:  Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#=  5 Spd=12  MxCh= 0
D:  Ver= 1.00 Cls=02(comm.) Sub=00 Prot=00 MxPS= 8 #Cfgs=  2
P:  Vendor=04c1 ProdID=3021 Rev= 0.82
S:  Manufacturer=3Com Inc.
S:  Product=U.S.Robotics 56000 Voice USB Modem
S:  SerialNumber=005605000000000E100D1A170000
C:* #Ifs= 1 Cfg#= 1 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
Quoted 8 lines
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
C:  #Ifs= 2 Cfg#= 2 Atr=60 MxPwr=  0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=02 Prot=01 Driver=(none)
E:  Ad=82(I) Atr=03(Int.) MxPS=  16 Ivl=128ms
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=(none)
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=  0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=  0ms

Looks like 2/2/1 had to math even with 2.4.10, but perhaps something is too subtle in the matching code.

This is what Vojtech wrote me about it (I hope he forgives me for posting a private mail - it is a technical subject):

Quoted 20 lines

Date: Tue, 2 Oct 2001 22:36:08 +0200
From: Vojtech Pavlik <[email protected]>
To: Pete Zaitcev <[email protected]>
Subject: Re: acm in 2.2.10

Quoted 14 lines · Pete Zaitcev

This looks dubious:

drivers/usb/acm.c +2 -1
@@ -647,7 +648,8 @@
  */
 
 static struct usb_device_id acm_ids[] = {
-	{ USB_DEVICE_INFO(2, 0, 0) },
+	{match_flags: (USB_DEVICE_ID_MATCH_INT_CLASS | USB_DEVICE_ID_MATCH_INT_SUBCLASS),
+	bInterfaceClass: USB_CLASS_COMM, bInterfaceSubClass: 2},
 	{ }
 };
 
Quoted 12 lines
Quoted 2 lines

Are you sure there are no 2/0/0 devices out there? Someone complained about some modem on Usenet today.

The change wasn't by me nor blessed by me, and it's wrong. It'll be reverted in following kernels. The problem is that 2/0/0 also matches the CDC Ethernet class, and thus both drivers get loaded for such devices via the hotplug mechanism. This works, but is slightly inefficient.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs

I think it is important to clear changes by the maintainer. That's what he is there for :)

-- Pete

#2 lore raw
In reply to Michael H. Warfield
Quoted 4 lines · Pete Zaitcev
Quoted 4 lines

From: "Michael H. Warfield" <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Date: Tue, 2 Oct 2001 18:47:57 -0400

	[...]
Quoted 34 lines

Looks like 2/2/1 had to math even with 2.4.10, but perhaps something is too subtle in the matching code.

This is what Vojtech wrote me about it (I hope he forgives me for posting a private mail - it is a technical subject):

Quoted 28 lines

Date: Tue, 2 Oct 2001 22:36:08 +0200
From: Vojtech Pavlik <[email protected]>
To: Pete Zaitcev <[email protected]>
Subject: Re: acm in 2.2.10

Quoted 14 lines · Pete Zaitcev

This looks dubious:

drivers/usb/acm.c +2 -1
@@ -647,7 +648,8 @@
  */
 
 static struct usb_device_id acm_ids[] = {
-	{ USB_DEVICE_INFO(2, 0, 0) },
+	{match_flags: (USB_DEVICE_ID_MATCH_INT_CLASS | USB_DEVICE_ID_MATCH_INT_SUBCLASS),
+	bInterfaceClass: USB_CLASS_COMM, bInterfaceSubClass: 2},
 	{ }
 };
 
Quoted 2 lines

Are you sure there are no 2/0/0 devices out there? Someone complained about some modem on Usenet today.

The change wasn't by me nor blessed by me, and it's wrong. It'll be reverted in following kernels. The problem is that 2/0/0 also matches the CDC Ethernet class, and thus both drivers get loaded for such devices via the hotplug mechanism. This works, but is slightly inefficient.

I'll confirm this. Backing out that change (which seems to be
the only real change to acm.c) corrected the problem and the modems are now recognized and operate under 2.4.10.

Quoted 6 lines
Quoted 3 lines
Signature · 2 lines
Vojtech Pavlik
SuSE Labs

I think it is important to clear changes by the maintainer. That's what he is there for :)

Tell me about it (I maintain the Computone multiport driver). :-)

Quoted 1 line

-- Pete

Mike

Signature · 4 lines
 Michael H. Warfield    |  (770) 985-6132   |  [email protected]
  (The Mad Wizard)      |  (678) 463-0932   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!