Skip to contentSkip to conversation

Missing wake_up in drivers/scsi/sg.c

BUG Taral 1 participant 1 message Oct 8, 2001

lore
Share & tools
lore

Taral

author
#0 lore raw

drivers/scsi/sg.c:319 (sg_open) (2.4.10-ac4) reads:

    if (flags & O_EXCL) sdp->exclude = 0; /* undo if error */

but this variable is linked to a waitlist. Should this not read thus?

    if (flags & O_EXCL) {
        sdp->exclude = 0;
        wake_up_interruptible(&sdp->o_excl_wait);
    }

It reads this way in sg_release.

Signature · 4 lines
Taral <[email protected]>
This message is digitally signed. Please PGP encrypt mail to me.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose