crc32 cleanups
Quoted 4 lines · [email protected] said:
Quoted 2 lines · [email protected] said:
Quoted 2 lines
That leaves (a) unconditionally building
it into the kernel, or (b)Makefileand Config.in rules.
Quoted 12 lines
Quoted 2 lines
(a) is simple, but needs a 1KB malloc (or alternately, a 1KB static const array - I've taken the approach that the malloc is better)
Better static (less overhead in size and at runtime), initialized at build time (you could compute it then). In case of _dire_ kernel size problems, it can be left out anyway. AFAIU, there are now a _lot_ of copies of this around, so you'll win overall in any case.
Quoted 4 lines
(b) isn't that much harder, but requires drivers to be sure to call
init_crc32andcleanup_crc32. If somehow they manage not to do that, Oops. I don't want to add a runtime check for the existance of the array incrc32().
I have to agree. A single global config that controls if CRC32 is available as a static table, and an inline function that allows me to use it.
Any module that tries to use it will either not compile or if will not load due an unresolved address.
Least impact. Simplest API. The lowest overhead for kernels that do or do not need CRC.
We should probably provide CRC10 and CRC16 as well.
Signature · 4 lines
__O Lineo - Where Open Meets Smart _-\<,_ PGP Fingerprint: 28 E2 A0 15 99 62 9A 00 (_)/ (_) 88 EC A3 EE 2D 1C 15 68 Stuart Lynne <[email protected]> www.lineo.com 604-461-7532