Skip to contentSkip to conversation

2.4.13pre3: &i_mapping used where i_mapping needed

PATCH New Chip Salzenberg 1 participant 1 message Oct 17, 2001

Subsystems (2)
Memory management Page cache
lore
Share & tools
lore

Chip Salzenberg

author
#0 lore raw

PATCH 1/1 2.4.13pre3: &i_mapping used where i_mapping needed

In 2.4.13pre3, mm/filemap.c:mincore_page() sets an address_space pointer to &inode->i_mapping. This is almost surely an error, because i_mapping is already a pointer.

A minimal patch is attached.

Signature · 2 lines
Chip Salzenberg               - a.k.a. -              <[email protected]>
 "We have no fuel on board, plus or minus 8 kilograms."  -- NEAR tech

Index: linux/mm/filemap.c

mm/filemap.c renamed from mm/filemap.c.old +1 -1
@@ -2449,5 +2449,5 @@
 {
 	unsigned char present = 0;
-	struct address_space * as = &vma->vm_file->f_dentry->d_inode->i_mapping;
+	struct address_space * as = vma->vm_file->f_dentry->d_inode->i_mapping;
 	struct page * page, ** hash = page_hash(as, pgoff);