Skip to contentSkip to conversation

to tidy up some orinoco driver log messages

PATCH In review Charles Briscoe-Smith 2 participants 2 messages Oct 18, 2001 Networking drivers (wireless)

lore
Share & tools
lore

Charles Briscoe-Smith

author
#0 lore raw

PATCH 1/1 to tidy up some orinoco driver log messages

This trivial patch cleans up a few missing newlines in some log messages in the Orinoco driver. Generated from linux-2.4.12 (orinoco.c 0.08a); should apply cleanly to linux-2.4.13-pre3.

drivers/net/wireless/orinoco.c +3 -3
diff -ur linux/drivers/net/wireless/orinoco.c linux-2.4.12/drivers/net/wireless/orinoco.c
@@ -1431,7 +1431,7 @@
 			priv->ibss_port = 0;
 		else {
 			printk(KERN_NOTICE "%s: Intersil firmware earlier "
-			       "than v0.08 - several features not supported.",
+			       "than v0.08 - several features not supported.\n",
 			       dev->name);
 			priv->ibss_port = 1;
 		}

@@ -1497,7 +1497,7 @@
 	err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CNF_NICKNAME,
 			      sizeof(nickbuf), &reclen, &nickbuf);
 	if (err) {
-		printk(KERN_ERR "%s: failed to read station name!n",
+		printk(KERN_ERR "%s: failed to read station name!\n",
 		       dev->name);
 		goto out;
 	}

@@ -1798,7 +1798,7 @@
 		if (err == -EIO)
 			DEBUG(1, "%s: DEBUG: EIO writing packet header to BAP\n", dev->name);
 		else
-			printk(KERN_ERR "%s: Error %d writing packet header to BAP",
+			printk(KERN_ERR "%s: Error %d writing packet header to BAP\n",
 			       dev->name, err);
 		stats->tx_errors++;
 		goto fail;
Signature · 6 lines
Charles Briscoe-Smith             Hacking Free Software for fun and profit
PGP/GPG:  1024R/B35EE811  74 68 AB 2E 1C 60 22 94  B8 21 2D 01 DE 66 13 E2
Governing Law:
   This License Agreement shall be construed and governed in accordance
   with the laws of the State of Inebriation. 
                                    -- http://www.thalia.org/computer.html
#1 lore raw
Quoted 3 lines · Charles Briscoe-Smith

This trivial patch cleans up a few missing newlines in some log messages in the Orinoco driver. Generated from linux-2.4.12 (orinoco.c 0.08a); should apply cleanly to linux-2.4.13-pre3.

Thanks. Merged.

Signature · 4 lines
David Gibson			| For every complex problem there is a
[email protected]	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson