Skip to contentSkip to conversation

small bug? in drivers/video/vgacon.c

PATCH Stepan Koltsov 1 participant 1 message Nov 1, 2001 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

Hi.

Function drivers/video/vgacon.c:vgacon_scrolldelta() doesn't work when get 1 or -1 as 2nd arg (it doesn't scroll).
This bug can be seen rarely, cos usually this func never called with 1 or -1. I don't quite understand, how this func works :-) but vgacon_scrolldelta works properly with this small patch.

drivers/video/vgacon.c +1 -1
diff -ur linux-2.4.12-orig/drivers/video/vgacon.c linux-2.4.12/drivers/video/vgacon.c
@@ -931,7 +931,7 @@
 		c->vc_visible_origin = c->vc_origin;
 	else {
 		int vram_size = vga_vram_end - vga_vram_base;
-		int margin = c->vc_size_row * 4;
+		int margin = c->vc_size_row;
 		int ul, we, p, st;
 
 		if (vga_rolled_over > (c->vc_scr_end - vga_vram_base) + margin) {
Signature · 2 lines
mailto:[email protected]
ICQ:26521795