Skip to contentSkip to conversation

driver initialisation order problem

DISCUSSION Tim Waugh 4 participants 8 messages Nov 1, 2001

lore
Share & tools
lore

Tim Waugh

author
#0 lore raw

drivers/char depends on drivers/parport (lp requires parport) drivers/parport depends on drivers/char (parport_serial requires serial)

How should this dependency be expressed? The link order of drivers/char and drivers/parport isn't enough.

Tim.
*/

#1 lore raw
Quoted 6 lines · Tim Waugh

drivers/char depends on drivers/parport (lp requires parport) drivers/parport depends on drivers/char (parport_serial requires serial)

How should this dependency be expressed? The link order of drivers/char and drivers/parport isn't enough.

I would move lp to parport, since IMHO it belongs there anyway.

Signature · 3 lines
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno
author
#2 lore raw
In reply to Tim Waugh
Quoted 1 line · Jeff Garzik

I would move lp to parport, since IMHO it belongs there anyway.

It isn't confined to just lp:

$ grep -l parport $(find drivers/char -name '*.c')
drivers/char/lp.c
drivers/char/ppdev.c
drivers/char/joystick/turbografx.c
drivers/char/joystick/db9.c
drivers/char/joystick/gamecon.c

Tim.
*/

#3 lore raw
In reply to Tim Waugh
Quoted 10 lines · Tim Waugh
Quoted 1 line · Jeff Garzik

I would move lp to parport, since IMHO it belongs there anyway.

It isn't confined to just lp:

$ grep -l parport $(find drivers/char -name '*.c')
drivers/char/lp.c
drivers/char/ppdev.c

I would move both of these to parport

Quoted 3 lines

drivers/char/joystick/turbografx.c
drivers/char/joystick/db9.c
drivers/char/joystick/gamecon.c

don't have a good answer. maybe move 'em to drivers/input :)

Signature · 3 lines
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno
#4 lore raw
Quoted 6 lines
Quoted 4 lines

drivers/char/joystick/turbografx.c
drivers/char/joystick/db9.c
drivers/char/joystick/gamecon.c

don't have a good answer. maybe move 'em to drivers/input :)

I suggested that before. Linus didn't like that. Actually in time you will see all input devices moved to drivers/input. It will become more and more a mess if we don't. I have various devices such as touchscreens, keyboard, joysticks etc that are serial devices. It is such a nasty hack at present to reach into char/joytsick to get something like a touchscreen working. IMO we should have things in the following order:

/drivers/serial -> Yes I plan a rewrite of the serial layer.
/drivers/parport
/drivers/usb

/driver/input
/driver/char -> The future console system will be inptu api
based so input needs to be first.

Things like hardware protocols, USB, RS232 should come first. Then char devices like input and things in char come next.

#6 lore raw
Quoted 5 lines · James Simmons
Quoted 1 line

/drivers/serial -> Yes I plan a rewrite of the serial layer.

Correction - I plan a major cleanup of the serial layer.

Better yet we both need important changes to the serial layer.

#7 lore raw
In reply to Russell King
Quoted 1 line · James Simmons

Better yet we both need important changes to the serial layer.

My priority as far as serial stuff goes is to keep what we now have stable so that the people who _need_ to use it (those in the ARM world) have a chance of stability.

This doesn mean that the input stuff as far as the serial side is concerned, and the other changes to integrate some parts of the serial layer into the tty layer as suggested by Ted will have to hold off for a while as the current implementation matures and stabilises.

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html