mmap + wrapping around to 0
I have a fix for this problem. In the fileinclude/linux/mm.h
in the inline function do_mmap(), change
if ((offset + PAGE_ALIGN(len)) < offset)
to
if ((offset + PAGE_ALIGN(len)-1) < offset)
-Dave
Quoted 12 lines · Dave Ashley
I'm using linux on an embedded system based on the 2.4.2 kernel. There is a flash rom at physical address FFE00000 of 2 megabytes size. I have a flash utility that uses
mmap()on/dev/mem, but I can't call it with offset0xffe00000, size0x00200000, I must call it with size0x001ff000(1 page size less than the real size). I figure this is because the end address has wrapped around to 0 and this messes up the system.This should work, the memory is there. But I can't access that last page.
BTW the cpu is a ppc 8260 (603e core).
-Dave
Quoted 4 lines
in the inline function
do_mmap(), change
if ((offset +PAGE_ALIGN(len)) < offset)
toif ((offset + PAGE_ALIGN(len)-1) < offset)
Shouldnt that be
PAGE_ALIGN(len-1)
so you compute the page of the last byte ?
PAGE_ALIGN results in a multiple of PAGE_SIZE always. If you subtract one inside, the end result will be the same.
As an example:
map 0x1000 bytes at 0xfffff000 PAGE_ALIGN(0x1000) = 0x1000 PAGE_ALIGN(0x0fff) = 0x1000 PAGE_ALIGN(0x1000)-1 = 0x0fff
The difference is adding 0x1000 or 0xfff to 0xfffff000, and the result wrapping around
to 0, or going to 0xffffffff (the later result is what we want and the comparison works).
-Dave
Quoted 16 lines · Alan Cox
Quoted 4 lines
in the inline function
do_mmap(), change
if ((offset +PAGE_ALIGN(len)) < offset)
toif ((offset + PAGE_ALIGN(len)-1) < offset)Shouldnt that be
PAGE_ALIGN(len-1)so you compute the page of the last byte ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/