Skip to contentSkip to conversation

isdn: isdnloop support crashes kernel when compiled in

DISCUSSION Mario 'BitKoenig' Holbe 2 participants 2 messages Nov 10, 2001 – Nov 11, 2001

lore
Share & tools
lore
#0 lore raw

Hoi,

The isdnloop support for the ISDN subsystem crashes the kernel when compiled in the kernel directly (null pointer reference). I guess, this is because parameters are only given as MODULE_PARM().

I found that in the 2.4.12 kernel, if it's fixed already in higher kernels, please excuse me :)

If this is a feature and not a bug, should'nt it then be forced to be configured as a module in the Config.in?

PS: I'm not member on the linux-kernel@ list, so please CC me in
replies, thanks.

regards,
Mario

Signature · 3 lines
*axiom* welcher sensorische input bewirkte die output-aktion,
        den irc-chatter mit dem nick "dus" des irc-servers
        mittels eines kills zu verweisen?
#1 lore raw
Quoted 9 lines · Mario 'BitKoenig' Holbe

The isdnloop support for the ISDN subsystem crashes the kernel when compiled in the kernel directly (null pointer reference). I guess, this is because parameters are only given as MODULE_PARM().

I found that in the 2.4.12 kernel, if it's fixed already in higher kernels, please excuse me :)

If this is a feature and not a bug, should'nt it then be forced to be configured as a module in the Config.in?

It's a bug. The appended patch should fix it.

--Kai

drivers/isdn/isdnloop/isdnloop.c +5 -1
diff -ur linux-2.4.15-pre2.patches/drivers/isdn/isdnloop/isdnloop.c linux-2.4.15-pre2.work/drivers/isdn/isdnloop/isdnloop.c
@@ -1542,7 +1542,11 @@
 	} else
 		strcpy(rev, " ??? ");
 	printk(KERN_NOTICE "isdnloop-ISDN-driver Rev%s\n", rev);
-	return (isdnloop_addcard(isdnloop_id));
+
+	if (isdnloop_id)
+		return (isdnloop_addcard(isdnloop_id));
+
+	return 0;
 }
 
 static void __exit