Skip to contentSkip to conversation

smp_call_function & BH handlers

DISCUSSION Maneesh Soni 2 participants 4 messages Nov 27, 2001

lore
Share & tools
lore
#0 lore raw

Hi,

Why is it ok to call smp_call_function from bottom half handlers? This could lead to deadlock in the way which we encounterd. (tried on 2.4.14 kernel)

CPU 0 CPU 1
----- -----
schedule() do_fork
read_lock(&tasklist_lock) spinning for write_lock_irq(&tasklist_lock)

	.
	.
	.

interrupted by a timer handler
calls smp_call_function()
waiting for response from CPU 1

IMO this looks like a genereic problem and not specific to tasklist_lock and can happen with other locks also. The solution for the above problem can be

(1) Do not use smp_call_function even from bottom half handlers.
(2) Enabling interrupts if CPU has to spin due to xxx_lock_irq() and disabling them when the CPU gets the lock.

Though the deadlock we faced doesnot occur, using read_lock_irq(&tasklist_lock) in schedule().

The comments above smp_call_function() also say that it can return negative status code upon failure. But it doesnot do that and keep waiting for response from other cpus. Why is it necessary to wait for response if we specify nowait in the parameter?

I hope I have not missed anything here.

Thanks
Maneesh

Signature · 5 lines
Maneesh Soni
IBM Linux Technology Center, 
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: [email protected]
http://lse.sourceforge.net/locking/rcupdate.html
#1 lore raw
Quoted 1 line · Maneesh Soni

Why is it ok to call smp_call_function from bottom half handlers? [...]

which part of the kernel is calling smp_call_function() from bh contexts?

Ingo

#2 lore raw
In reply to Maneesh Soni
Quoted 8 lines · Ingo Molnar
Quoted 1 line · Maneesh Soni

Why is it ok to call smp_call_function from bottom half handlers? [...]

which part of the kernel is calling smp_call_function() from bh contexts?

Ingo

I am working with Dipankar on Read-Copy Update, and experimenting with smp_call_function(). We believed the comments for this routine and faced this problem. That's why this question came. I have not yet searched kernel sources for such places hence not sure whether there are really such places or not.

Maneesh

Signature · 5 lines
Maneesh Soni
IBM Linux Technology Center, 
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: [email protected]
http://lse.sourceforge.net/locking/rcupdate.html
#3 lore raw
Quoted 5 lines · Maneesh Soni

I am working with Dipankar on Read-Copy Update, and experimenting with smp_call_function(). We believed the comments for this routine and faced this problem. That's why this question came. I have not yet searched kernel sources for such places hence not sure whether there are really such places or not.

we had similar lockup problems before, eg. TLB flushes initiated from IRQ/BH contexts - which is illegal now. Generally it's not safe to assume that every CPU is responsive to synchronous events triggered from IRQ/BH contexts. Every read_lock user is prone to this problem.

Ingo