Skip to contentSkip to conversation

ENTRY macro (coda maintainers please listen)

DISCUSSION Pavel Machek 2 participants 3 messages Dec 2, 2001 – Dec 4, 2001

lore
Share & tools
lore
#0 lore raw

Hi!

linux/linkage.h includes macro "ENTRY(a)", while linux/coda_linux includes ... macro "ENTRY".

It would be good to rename one of them (they are probably not needed in one module, anyway, that's not clean)...

Oh and there's no entry for CODA in MAINTAINERS file. You probably want to fix that.
Pavel

Signature · 2 lines
"I do not steal MS software. It is not worth it."
                                -- Pavel Kankovsky
#1 lore raw
Quoted 2 lines · Pavel Machek

linux/linkage.h includes macro "ENTRY(a)", while linux/coda_linux includes ... macro "ENTRY".

That could lead to a possible problem. We're just lucky that no file in the Coda code has __ASSEMBLY__ defined.

Quoted 2 lines

It would be good to rename one of them (they are probably not needed in one module, anyway, that's not clean)...

Actually all coda_XXX.h files don't even have to be in include/linux/, only coda.h contains structs/defines that should be 'visible' outside of the Coda kernel code, anything else should just go to fs/coda and get a good dust off to remove a bunch of cruft.

Quoted 2 lines

Oh and there's no entry for CODA in MAINTAINERS file. You probably want to fix that.

Gee, oh well. I didn't consider it 'critical bug-fixes only' or important enough to push a patch for a maintainers entry into a stable series, and obviously wasn't paying attention during 2.3 development.

Besides I've been sending you updates whenever something critical changes in coda.o (considering you are using it for podfuk). I would figure that of all people at least you would know.

Jan

#2 lore raw
In reply to Pavel Machek

Hi!

Quoted 7 lines
Quoted 2 lines

It would be good to rename one of them (they are probably not needed in one module, anyway, that's not clean)...

Actually all coda_XXX.h files don't even have to be in include/linux/, only coda.h contains structs/defines that should be 'visible' outside of the Coda kernel code, anything else should just go to fs/coda and get a good dust off to remove a bunch of cruft.

There's no reason to move them... include/linux is as good place as fs/coda.

Quoted 7 lines
Quoted 2 lines

Oh and there's no entry for CODA in MAINTAINERS file. You probably want to fix that.

Gee, oh well. I didn't consider it 'critical bug-fixes only' or important enough to push a patch for a maintainers entry into a stable series, and obviously wasn't paying attention during 2.3 development.

It is bug-fix, and very easy to see it does not break anything. *That* kind of fixes is welcome anytime ;-).

Quoted 3 lines

Besides I've been sending you updates whenever something critical changes in coda.o (considering you are using it for podfuk). I would figure that of all people at least you would know.

(-: Sorry.
Pavel

Signature · 2 lines
Casualities in World Trade Center: 6453 dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.