small doc update for /proc/sys/net/ipv4/icmp_rate{mask,limit}
Subsystems (3)
PATCH 1/1 small doc update for /proc/sys/net/ipv4/icmp_rate{mask,limit}
Hi,
Comments in the C code are incorrect and the documentation is outdated.
Attached patch is for 2.4.17-pre8 but probably applies cleanly against 2.5.x too.
Signature · 2 lines
Best regards, Pierre Lombard
Documentation/networking/ip-sysctl.txt +13 -6
@@ -309,13 +309,20 @@ ICMP ECHO requests sent to it or just those to broadcast/multicast addresses, respectively. -icmp_destunreach_rate - INTEGER -icmp_paramprob_rate - INTEGER -icmp_timeexceed_rate - INTEGER -icmp_echoreply_rate - INTEGER (not enabled per default) - Limit the maximal rates for sending ICMP packets to specific targets. +icmp_ratelimit - INTEGER + Limit the maximal rates for sending ICMP packets whose type matches + icmp_ratemask (see below) to specific targets. 0 to disable any limiting, otherwise the maximal rate in jiffies(1) - See the source for more information. + Default: 1 + +icmp_ratemask - INTEGER + Mask made of ICMP types for which rates are being limited. + Default: 6168 + Note: 6168 = 0x1818 = 1<<ICMP_DEST_UNREACH + 1<<ICMP_SOURCE_QUENCH + + 1<<ICMP_TIME_EXCEEDED + 1<<ICMP_PARAMETERPROB, which means + dest unreachable (3), source quench (4), time exceeded (11) + and parameter problem (12) ICMP packets are rate limited + (check values in icmp.h) icmp_ignore_bogus_error_responses - BOOLEAN Some routers violate RFC 1122 by sending bogus responses to broadcast
net/ipv4/icmp.c +2 -2
@@ -154,8 +154,8 @@* it's bit position. * * default: -* dest unreachable (0x03), source quench (0x04), -* time exceeded (0x11), parameter problem (0x12) +* dest unreachable (3), source quench (4), +* time exceeded (11), parameter problem (12) */ int sysctl_icmp_ratelimit =1 *HZ ;
Your patch does not apply, did you edit this patch by hand before submitting it? The "#lines" in the patch chunks are inaccurate.
Quoted 3 lines · David S. Miller
Your patch does not apply, did you edit this patch by hand before submitting it? The "#lines" in the patch chunks are inaccurate.
Yes. I didn't thought it would break since it applied cleanly here but it did :)
A fresh & unedited version against a vanilla 2.4.17-pre8 is text-attached.
Signature · 2 lines
Best regards, Pierre Lombard
Documentation/networking/ip-sysctl.txt +13 -6
@@ -309,13 +309,20 @@ ICMP ECHO requests sent to it or just those to broadcast/multicast addresses, respectively. -icmp_destunreach_rate - INTEGER -icmp_paramprob_rate - INTEGER -icmp_timeexceed_rate - INTEGER -icmp_echoreply_rate - INTEGER (not enabled per default) - Limit the maximal rates for sending ICMP packets to specific targets. +icmp_ratelimit - INTEGER + Limit the maximal rates for sending ICMP packets whose type matches + icmp_ratemask (see below) to specific targets. 0 to disable any limiting, otherwise the maximal rate in jiffies(1) - See the source for more information. + Default: 1 + +icmp_ratemask - INTEGER + Mask made of ICMP types for which rates are being limited. + Default: 6168 + Note: 6168 = 0x1818 = 1<<ICMP_DEST_UNREACH + 1<<ICMP_SOURCE_QUENCH + + 1<<ICMP_TIME_EXCEEDED + 1<<ICMP_PARAMETERPROB, which means + dest unreachable (3), source quench (4), time exceeded (11) + and parameter problem (12) ICMP packets are rate limited + (check values in icmp.h) icmp_ignore_bogus_error_responses - BOOLEAN Some routers violate RFC 1122 by sending bogus responses to broadcast
net/ipv4/icmp.c +2 -2
@@ -154,8 +154,8 @@* it's bit position. * * default: -* dest unreachable (0x03), source quench (0x04), -* time exceeded (0x11), parameter problem (0x12) +* dest unreachable (3), source quench (4), +* time exceeded (11), parameter problem (12) */ int sysctl_icmp_ratelimit =1 *HZ ;
David S. Miller
Applied From: Pierre Lombard <[email protected]>
Date: Thu, 13 Dec 2001 09:57:49 +0100
A fresh & unedited version against a vanilla 2.4.17-pre8 is text-attached.
Applied, thanks.