Skip to contentSkip to conversation

2.4.17 build fails at network.o

DISCUSSION se d 3 participants 3 messages Dec 22, 2001

Subsystems (2)
lore
Share & tools
lore

se d

author
#0 lore raw

I'm trying to build 2.4.17. It fails as follows:

make[1]: Leaving directory `/opt/kernel/linux-2.4.17/arch/i386/lib'
ld -m elf_i386 -T /opt/kernel/linux-2.4.17/arch/i386/vmlinux.lds -e stext arch/i386/kernel/head.o arch/i386/kernel/init_tas

k.o init/main.o init/version.o \
	--start-group \
	arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o mm/mm.o fs/fs.o 

ipc/ipc.o \
drivers/char/char.o drivers/block/block.o drivers/misc/misc.o
drivers/net/net.o drivers/media/media.o drivers/char
/agp/agp.o drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/cdrom/driver.o drivers/sound/sounddrivers.o drivers/pci/d

river.o drivers/pnp/pnp.o drivers/video/video.o drivers/md/mddev.o \
	net/network.o \
	/opt/kernel/linux-2.4.17/arch/i386/lib/lib.a 
/opt/kernel/linux-2.4.17/lib/lib.a /opt/kernel/linux-2.4.17/arch/i386/
lib/lib.a \
	--end-group \
	-o vmlinux

net/network.o: In function `__rpc_schedule':
net/network.o(.text+0x49a0d): undefined reference to `rpciod_tcp_dispatcher'
make: *** [vmlinux] Error 1

_________________________________________________________________
Chat with friends online, try MSN Messenger: http://messenger.msn.com

#1 lore raw

This should fix it:

sunrpc/sched.c renamed from sunrpc/sched.c.~1~ +1 -0
@@ -21,6 +21,7 @@
 #include <linux/spinlock.h>
 
 #include <linux/sunrpc/clnt.h>
+#include <linux/sunrpc/xprt.h>
 
 #ifdef RPC_DEBUG
 #define RPCDBG_FACILITY		RPCDBG_SCHED
#2 lore raw
In reply to se d
Quoted 4 lines · you

I'm trying to build 2.4.17. It fails as follows:

net/network.o: In function `__rpc_schedule':
net/network.o(.text+0x49a0d): undefined reference to `rpciod_tcp_dispatcher'

I've seen this problem while trying to compile recent kernels with RedHat Rawhide's gcc-3.10-0.1, are you using that?

I traced the problem to a conflict in include/linux/sunrpc/clnt.h. It declares rpciod_tcp_dispatcher as extern, but it also includes linux/sunrpc/xprt.h, which has a static inline definition of rpciod_tcp_dispatcher. Previous versions of gcc seem to choose the static inline definition, while gcc-3.10-0.1 chooses the extern declaration. So I simply deleted the extern declaration from linux/sunrpc/clnt.h.

With this change, the kernel compiles but oopses in do_signal() shortly after booting. [email protected] logged a similar conflict in RedHat Bugzilla 57413, which I paraphrase here: do_signal() is delcared as asmlinkage int FASTCALL in arch/i386/kernel/signal.c, but asmlinkage gives the attribute regparm(0), while FASTCALL gives the attribute regparm(3). Again, prior versions of gcc chose regparm(3), while gcc-3.1-0.10 chooses regparm(0). So I simply deleted the asmlinkage declaration.

With these two small changes, kernel 2.4.17 compiles with gcc-3.1-0.10 and boots on my i386 machine OK. In fact, I'm writing this under it now. However:

[whitney@pizza linux-2.4.17-gcc-3.1-0.10]$ grep -r "asmlinkage.*FASTCALL" . ./arch/i386/kernel/vm86.c:asmlinkage struct pt_regs * FASTCALL(save_v86_state(struct kernel_vm86_regs * regs)); ./arch/s390/kernel/signal.c:asmlinkage int FASTCALL(do_signal(struct pt_regs *regs, sigset_t *oldset)); ./arch/s390x/kernel/signal.c:asmlinkage int FASTCALL(do_signal(struct pt_regs *regs, sigset_t *oldset)); ./arch/s390x/kernel/signal32.c:asmlinkage int FASTCALL(do_signal(struct pt_regs *regs, sigset_t *oldset));

Maybe some of these need cleaning up? I'll have to leave that to the experts, I'm more of a grease monkey.

Cheers,
Wayne

include/linux/sunrpc/clnt.h +0 -1
diff -rup linux-2.4.17/include/linux/sunrpc/clnt.h linux-2.4.17-gcc-3.1-0.10/include/linux/sunrpc/clnt.h
@@ -136,7 +136,6 @@ rpc_set_timeout(struct rpc_clnt *clnt, u
 	xprt_set_timeout(&clnt->cl_timeout, retr, incr);
 }
 
-extern void rpciod_tcp_dispatcher(void);
 extern void rpciod_wake_up(void);
 
 /*
arch/i386/kernel/signal.c +1 -1
diff -rup linux-2.4.17/arch/i386/kernel/signal.c linux-2.4.17-gcc-3.1-0.10/arch/i386/kernel/signal.c
@@ -28,7 +28,7 @@
 
 #define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
 
-asmlinkage int FASTCALL(do_signal(struct pt_regs *regs, sigset_t *oldset));
+int FASTCALL(do_signal(struct pt_regs *regs, sigset_t *oldset));
 
 int copy_siginfo_to_user(siginfo_t *to, siginfo_t *from)
 {