Skip to contentSkip to conversation

what file to put a particular function in?

DISCUSSION Phil Howard 1 participant 1 message Dec 27, 2001

lore
Share & tools
lore
#0 lore raw

In 2.4.17, the show_trace_task() function for sparc32 finally showed up. The problem was, it was moved from traps.c to process.c. The confusion is that in other platforms it is in traps.c, not process.c. DaveM mentions in past posting that this is arbitrary. My question is, just what is the scope of such arbitrary decisions? And is there even any need to keep traps.c and process.c separate if functions can be freely traded between them?

There is inconsistency. At least show_trace_task() shows up in some platforms in one file, and in other platforms in another. This differs even in related platforms like sparc32 (it's in process.c) and sparc64 (it's in traps.c). I believe there needs to be some kind of uniform consistency between platforms where possible. Unless some special constraint exists in a platform, I believe any function should show up in the same place relative to the specific asm- tree.

I'm sure such changes really would not be wise for the remaining 2.4 sequence. But what about 2.5? Could this not be included as a goal in the 2.5 tree, to get functions located more consistently?

Signature · 4 lines
-----------------------------------------------------------------
| Phil Howard - KA9WGN |   Dallas   | http://linuxhomepage.com/ |
| [email protected] | Texas, USA | http://phil.ipal.org/     |
-----------------------------------------------------------------