Skip to contentSkip to conversation

Bogus devfs ChangeLog change in 2.5.2-pre4

PATCH In review Richard Gooch 3 participants 3 messages Dec 30, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bogus devfs ChangeLog change in 2.5.2-pre4

Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
is not necessary and obviously wrong (the ChangeLog was correct previously). Please revert.

Looks like the result of an automated global search-and-replace (i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't performed by the guilty party.
</grumble>

				Regards,

					Richard....
Permanent: [email protected]
Current:   [email protected]
fs/devfs/base.c +0 -1
diff -urN linux-2.5.2-pre3/fs/devfs/base.c linux/fs/devfs/base.c
@@ -517,7 +517,6 @@
     20010730   Richard Gooch <[email protected]>
 	       Added DEVFSD_NOTIFY_DELETE event.
     20010801   Richard Gooch <[email protected]>
-	       Removed #include <asm/segment.h>.
   v0.109
     20010807   Richard Gooch <[email protected]>
 	       Fixed inode table races by removing it and using
#1 lore raw
Quoted 8 lines · Richard Gooch

Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
is not necessary and obviously wrong (the ChangeLog was correct previously). Please revert.

Looks like the result of an automated global search-and-replace (i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't performed by the guilty party.
</grumble>

That's not the only thing. There's also a load of:

#else
#endif

constructs now as well that need cleaning up.

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
#2 lore raw
In reply to Richard Gooch
Quoted 7 lines · Richard Gooch

Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
is not necessary and obviously wrong (the ChangeLog was correct previously). Please revert.

Looks like the result of an automated global search-and-replace (i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't performed by the guilty party.

dwmw2's handywork from my tree.
I read this diff a half dozen times, and given Linus' scrutiny over the other bits I've shoved him today, I guess he overlooked it too.. Typically, I spotted it whilst merging pre4 with my tree.. Weirdness.

Dave.

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs