Skip to contentSkip to conversation

mmap/munmap in sysfs

PATCH Bjorn Helgaas 3 participants 3 messages Jun 25, 2019 – Jun 26, 2019 PCI

lore
Share & tools
lore
#0 lore raw

Hi Greg, et al,

Userspace can mmap PCI device memory via the resourceN files in sysfs, which use pci_mmap_resource(). I think this path is unaware of power management, so the device may be runtime-suspended, e.g., it may be in D1, D2, or D3, where it will not respond to memory accesses.

Userspace accesses while the device is suspended will cause PCI errors, so I think we need something like the patch below. But this isn't sufficient by itself because we would need a corresponding pm_runtime_put() when the mapping goes away. Where should that go? Or is there a better way to do this?

drivers/pci/pci-sysfs.c +1 -0
index 6d27475e39b2..aab7a47679a7 100644
@@ -1173,6 +1173,7 @@ static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr,
 
 	mmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;
 
+	pm_runtime_get_sync(pdev);
 	return pci_mmap_resource_range(pdev, bar, vma, mmap_type, write_combine);
 }
 
#1 lore raw
Quoted 19 lines · Bjorn Helgaas

Hi Greg, et al,

Userspace can mmap PCI device memory via the resourceN files in sysfs, which use pci_mmap_resource(). I think this path is unaware of power management, so the device may be runtime-suspended, e.g., it may be in D1, D2, or D3, where it will not respond to memory accesses.

Userspace accesses while the device is suspended will cause PCI errors, so I think we need something like the patch below. But this isn't sufficient by itself because we would need a corresponding pm_runtime_put() when the mapping goes away. Where should that go? Or is there a better way to do this?

drivers/pci/pci-sysfs.c +0 -0
index 6d27475e39b2..aab7a47679a7 100644

drivers/pci/pci-sysfs.c static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr, · line 1179

Quoted 7 lines
drivers/pci/pci-sysfs.c +1 -0
@@ -1173,6 +1173,7 @@ static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr,
 
 	mmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;
 
+	pm_runtime_get_sync(pdev);
 	return pci_mmap_resource_range(pdev, bar, vma, mmap_type, write_combine);
 }
 

Ugh, we never thought about this when adding the mmap sysfs interface all those years ago :(

I think you are right, this will not properly solve the issue, but I don't know off the top of my head where to solve this. Maybe Rafael has a better idea as he knows the pm paths much better than I do?

thanks,

greg k-h

#2 lore raw
Quoted 31 lines · CEST Greg Kroah-Hartman
Quoted 19 lines · Bjorn Helgaas

Hi Greg, et al,

Userspace can mmap PCI device memory via the resourceN files in sysfs, which use pci_mmap_resource(). I think this path is unaware of power management, so the device may be runtime-suspended, e.g., it may be in D1, D2, or D3, where it will not respond to memory accesses.

Userspace accesses while the device is suspended will cause PCI errors, so I think we need something like the patch below. But this isn't sufficient by itself because we would need a corresponding pm_runtime_put() when the mapping goes away. Where should that go? Or is there a better way to do this?

drivers/pci/pci-sysfs.c +0 -0
index 6d27475e39b2..aab7a47679a7 100644

drivers/pci/pci-sysfs.c static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr, · line 1179

Quoted 7 lines
drivers/pci/pci-sysfs.c +1 -0
@@ -1173,6 +1173,7 @@ static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr,
 
 	mmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;
 
+	pm_runtime_get_sync(pdev);
 	return pci_mmap_resource_range(pdev, bar, vma, mmap_type, write_combine);
 }
 

Ugh, we never thought about this when adding the mmap sysfs interface all those years ago :(

Quoted 3 lines

I think you are right, this will not properly solve the issue, but I don't know off the top of my head where to solve this. Maybe Rafael has a better idea as he knows the pm paths much better than I do?

Well, let me think about this a bit.