Skip to contentSkip to conversation

bad patch in aic7xxx_linux.c

DISCUSSION Nathan Myers 4 participants 6 messages Jan 9, 2002 – Jan 11, 2002

lore
Share & tools
lore
#0 lore raw

Marcelo,

In patch-2.4.17-pre2, a nonsensical change was made in linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently harmless, it suggests to me that you had intended to fold in an entirely different patch, and "missed".

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

Nathan Myers
ncm at cantrip dot org

#1 lore raw

From: Nathan Myers <[email protected]>
Date: Wed, 9 Jan 2002 09:06:28 +0000

In patch-2.4.17-pre2, a nonsensical change was made in linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently harmless, it suggests to me that you had intended to fold in an entirely different patch, and "missed".

Missed? That patch fixes a lethal bug.

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

It's listed in the aic7xxx sources, but the fix in question came to Marcelo via Jens Axboe.

Franks a lot,
David S. Miller
[email protected]

#2 lore raw
In reply to Nathan Myers
Quoted 8 lines · Nathan Myers

Marcelo,

In patch-2.4.17-pre2, a nonsensical change was made in linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently harmless, it suggests to me that you had intended to fold in an entirely different patch, and "missed".

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

Its not nonsensical: It fixes a critical bug as David pointed out.

#3 lore raw
In reply to Nathan Myers
Quoted 7 lines · David S. Miller

From: Nathan Myers <[email protected]>

Quoted 4 lines

In patch-2.4.18-pre2, a nonsensical change was made in linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently harmless, it suggests to me that you had intended to fold in an entirely different patch, and "missed".

Missed? That patch fixes a lethal bug.

Indeed, I missed that the value was also passed to ahc_linux_map_seg() before being clobbered in the next statement.

Quoted 4 lines

I don't find a current maintainer for aic7xxx listed in MAINTAINERS.

It's listed in the aic7xxx sources, but the fix in question came to Marcelo via Jens Axboe.

One can guess, but there are no addresses for anyone noted there later than 1999. In particular, Justin's address isn't listed.

I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting an Oops shortly related to that, unless somebody tells me not to bother.

Nathan Myers
ncm at cantrip dot org

#4 lore raw
Quoted 2 lines

One can guess, but there are no addresses for anyone noted there later than 1999. In particular, Justin's address isn't listed.

I monitor this list. A Yahoo search using my name provides several hits for my email address.

Quoted 2 lines

I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting an Oops shortly related to that, unless somebody tells me not to bother.

Feel free to send me the oops.

--
Justin

#5 lore raw

From: "Justin T. Gibbs" <[email protected]>
Date: Thu, 10 Jan 2002 10:59:16 -0700

Quoted 2 lines

One can guess, but there are no addresses for anyone noted there later than 1999. In particular, Justin's address isn't listed.

I monitor this list. A Yahoo search using my name provides several hits for my email address.

Your contact information really ought to be up to date in the sources and linux/MAINTAINERS