Skip to contentSkip to conversation

Suppress compilation warnings on big endian platform for reiserfs

PATCH In review Oleg Drokin 2 participants 7 messages Jan 9, 2002

lore
Share & tools
lore

Oleg Drokin

author
#0 lore raw

PATCH 1/1 Suppress compilation warnings on big endian platform for reiserfs

Hello!

Please apply.

Bye,
Oleg

include/linux/reiserfs_fs.h renamed from include/linux/reiserfs_fs.h.orig +4 -4
@@ -244,9 +244,9 @@
     __u64 linear;
 } __attribute__ ((__packed__)) offset_v2_esafe_overlay;
 
-static inline __u16 offset_v2_k_type( struct offset_v2 *v2 )
+static inline __u16 offset_v2_k_type( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const constoffset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return (tmp.offset_v2.k_type <= TYPE_MAXTYPE)?tmp.offset_v2.k_type:TYPE_ANY;
 }

@@ -259,9 +259,9 @@
     tmp->linear = le64_to_cpu(tmp->linear);
 }
  
-static inline loff_t offset_v2_k_offset( struct offset_v2 *v2 )
+static inline loff_t offset_v2_k_offset( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return tmp.offset_v2.k_offset;
 }
author
#1 lore raw

Hello!

Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one. Please apply this one.

Bye,
Oleg

Quoted 1 line · Oleg Drokin

Please apply.

include/linux/reiserfs_fs.h renamed from include/linux/reiserfs_fs.h.orig +4 -4
@@ -244,9 +244,9 @@
     __u64 linear;
 } __attribute__ ((__packed__)) offset_v2_esafe_overlay;
 
-static inline __u16 offset_v2_k_type( struct offset_v2 *v2 )
+static inline __u16 offset_v2_k_type( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return (tmp.offset_v2.k_type <= TYPE_MAXTYPE)?tmp.offset_v2.k_type:TYPE_ANY;
 }

@@ -259,9 +259,9 @@
     tmp->linear = le64_to_cpu(tmp->linear);
 }
  
-static inline loff_t offset_v2_k_offset( struct offset_v2 *v2 )
+static inline loff_t offset_v2_k_offset( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return tmp.offset_v2.k_offset;
 }
#2 lore raw

Oleg,

Can you please queue all of this patches for the next -pre1 in one big update instead sending me a lot of daily small

Quoted 10 lines · Oleg Drokin

Hello!

Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one. Please apply this one.

Bye,
Oleg

Quoted 1 line · Oleg Drokin

Please apply.

#3 lore raw

Oops, pressed wrong key, sorry. ;)

Well, keeping with the story... Can you please queue all of this patches for the next -pre1 in one big update instead sending me a lot of daily small patches ?

I will obviously accept straight bugfixes at virtually any time.

Quoted 20 lines · Marcelo Tosatti

Oleg,

Can you please queue all of this patches for the next -pre1 in one big update instead sending me a lot of daily small

Quoted 10 lines · Oleg Drokin

Hello!

Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one. Please apply this one.

Bye,
Oleg

Quoted 1 line · Oleg Drokin

Please apply.

author
#4 lore raw
In reply to Oleg Drokin

Hello!

Sure, I can. Reason for sending small patches, is because Linus have requested people to send stuff in that way. BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)

Bye,
Oleg

Quoted 19 lines · Marcelo Tosatti

Oleg,

Can you please queue all of this patches for the next -pre1 in one big update instead sending me a lot of daily small

Quoted 10 lines · Oleg Drokin

Hello!

Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one. Please apply this one.

Bye,
Oleg

Quoted 1 line · Oleg Drokin

Please apply.

#5 lore raw
Quoted 5 lines · Oleg Drokin

Hello!

Sure, I can. Reason for sending small patches, is because Linus have requested people to send stuff in that way.

BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)

No, I'm just saying that you should send me non-bugfixes patches on -pre1 kernels.

Thanks.

author
#6 lore raw
In reply to Oleg Drokin

Hello!

Quoted 3 lines · Marcelo Tosatti
Quoted 1 line

BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)

No, I'm just saying that you should send me non-bugfixes patches on -pre1 kernels.

Ah, ok.

Bye,
Oleg