Skip to contentSkip to conversation

2.5: I/O errors ignored in __scsi_end_request

PATCH Peter Osterlund 2 participants 2 messages Jan 13, 2002 – Jan 14, 2002 SCSI

lore
Share & tools
lore
#0 lore raw

I/O errors in scsi drivers are being silently ignored in the __scsi_end_request function in scsi_lib.c. This patch seems obvious enough to me. (And it does work, at least for the packet writing module.)

drivers/scsi/scsi_lib.c renamed from drivers/scsi/scsi_lib.c.old +1 -1
@@ -365,7 +365,7 @@
 	 * If there are blocks left over at the end, set up the command
 	 * to queue the remainder of them.
 	 */
-	if (end_that_request_first(req, 1, sectors)) {
+	if (end_that_request_first(req, uptodate, sectors)) {
 		if (!requeue)
 			return SCpnt;
 
Signature · 2 lines
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340
#1 lore raw
Quoted 8 lines · Peter Osterlund

I/O errors in scsi drivers are being silently ignored in the __scsi_end_request function in scsi_lib.c. This patch seems obvious enough to me. (And it does work, at least for the packet writing module.)

drivers/scsi/scsi_lib.c line 370

Quoted 7 lines
drivers/scsi/scsi_lib.c renamed from drivers/scsi/scsi_lib.c.old +1 -1
@@ -365,7 +365,7 @@
 	 * If there are blocks left over at the end, set up the command
 	 * to queue the remainder of them.
 	 */
-	if (end_that_request_first(req, 1, sectors)) {
+	if (end_that_request_first(req, uptodate, sectors)) {
 		if (!requeue)
 			return SCpnt;

Irk, what a silly. Thanks, patch is obviously correct.

Signature · 1 line
Jens Axboe