Skip to contentSkip to conversation

Peeling off dcache_lock

RFC Rusty Russell 1 participant 1 message Jan 28, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Rusty Russell

author
#1 lore raw
Quoted 8 lines · On Fri, 25 Jan 2002 11:44:11 +0530 Maneesh Soni <[email protected]> wrote:
Quoted 3 lines · Rusty Russell

Hi Maneesh!

Fantastic work! A couple of questions, and a trivial patch:

Hi Rusty,

Thanks for code review.

Hey, anything that wins 20% on (32-way) dbench is worth reading 8)

Quoted 8 lines
Quoted 5 lines

o Am I correct in asserting that you could change all the "list_empty(dentry->dhash)" tests to
"dentry->d_vfs_flags & DCACHE_DEFERRED_FREE" tests, and hence change the list_del_init() to list_del() in unhash, and thus remove the d_nexthash field altogether?

I agree that d_next_hash is a sort of hack and want to remove it. I think we have tried removing it in the way you are suggesting. But we never got a stable code. I will have to look at this some what more.

Hmm... I finally have a dual x86 box here, so I can play with this as well.

Quoted 3 lines
Quoted 2 lines

o d_lookup looks like it can return an DCACHE_DEFERRED_FREE dentry: this seems wrong: shouldn't it loop here?

Actually d_lookup will fail if the found dentry has DCACHE_DEFERRED_FREE set.

ACK. Sorry, my mistake.

Quoted 1 line

I will do all these corrections in the next version very soon.

I wouldn't say "corrections": your code is very nice. I'm looking forward to your next iteration!

Quoted 3 lines
Quoted 1 line

Any chance of you making it to http://linux.conf.au next month BTW?

Probably not as I am getting married next month ;-) and lots of shopping is still remaining ;-).

Oh, congratulations! Perhaps I shall have to find a conference in India then 8)

Thanks!
Rusty.

Signature · 1 line
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.