Skip to contentSkip to conversation

fixup descriptions in pci-pc.c

PATCH In review Oliver Feiler 4 participants 8 messages Feb 3, 2002 – Feb 4, 2002

lore
Share & tools
lore

Oliver Feiler

author
#0 lore raw

Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk
text in pci_fixup_via_northbridge_bug in pci-pc.c was changed

- printk("Trying to stomp on VIA Northbridge bug...\n");
+ printk("Disabling broken memory write queue.\n");

Can't we change this to some meaningful output in 2.4.18 as well? It's
still the old text with pre7.

Bye

Oliver

Signature · 3 lines
Oliver Feiler                                               [email protected]
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/
#1 lore raw

Good idea. I frankly hate that message as its vague and stupid. Heh. I actually wrote it... but I did it as a patch to an older message and I didn't want to really change the poetic essence of the function I modified.

Feel free to patch this yourself. I am a bit afraid to bug alan and linus and marcello with such a small change :)

-Calin

Quoted 14 lines · Oliver Feiler

Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk
text in pci_fixup_via_northbridge_bug in pci-pc.c was changed

- printk("Trying to stomp on VIA Northbridge bug...\n");
+ printk("Disabling broken memory write queue.\n");

Can't we change this to some meaningful output in 2.4.18 as well? It's
still the old text with pre7.

Bye

Oliver

author
#2 lore raw

PATCH 1/1 (was: Re: fixup descriptions in pci-pc.c)

In reply to Oliver Feiler

Hello,

This just changes the printk in the via_northbridge_bug fixup to some
more meaningful output as it is already in 2.5.3. Please apply.

Oliver

arch/i386/kernel/pci-pc.c +1 -1
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling broken memory write queue.\n");
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}
Signature · 3 lines
Oliver Feiler                                               [email protected]
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/
#3 lore raw

Re: [Patch] (was: Re: fixup descriptions in pci-pc.c)

Woo hoo! The new message is much better!!

Also, speaking of the pci-pc.c fixup for via.. I hear for some people it causes massive system instability.. :( Although for me it was the answer to my woes. What to do about that?

-Calin

Quoted 21 lines · Oliver Feiler

Hello,

This just changes the printk in the via_northbridge_bug fixup to some
more meaningful output as it is already in 2.5.3. Please apply.

Oliver

arch/i386/kernel/pci-pc.c +1 -1
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling broken memory write queue.\n");
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}
#4 lore raw
In reply to Oliver Feiler
Quoted 8 lines · Oliver Feiler

Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk text in pci_fixup_via_northbridge_bug in pci-pc.c was changed

- printk("Trying to stomp on VIA Northbridge bug...\n");
+ printk("Disabling broken memory write queue.\n");

Can't we change this to some meaningful output in 2.4.18 as well? It's
still the old text with pre7.

Probably. + [reg]: old->new or similar
--
vda

author
#5 lore raw
In reply to Oliver Feiler
Quoted 2 lines · Denis Vlasenko

Probably. + [reg]: old->new or similar

Ok. Better with this?

arch/i386/kernel/pci-pc.c +1 -1
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling VIA memory write queue. Clearing bits 5, 6, 7 at 0x%x.\n", where);
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}
Signature · 3 lines
Oliver Feiler                                               [email protected]
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/
#6 lore raw
In reply to Oliver Feiler
Quoted 15 lines · Oliver Feiler
Quoted 1 line · Denis Vlasenko

Probably. + [reg]: old->new or similar

Ok. Better with this?

arch/i386/kernel/pci-pc.c +0 -0

2002 @@ -1129,7 +1129,7 @@

arch/i386/kernel/pci-pc.c +1 -1
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling VIA memory write queue. Clearing bits 5, 6, 7 at

0x%x.\n", where); v &= 0x1f; /* clear bits 5, 6, 7 */

arch/i386/kernel/pci-pc.c

Quoted 2 lines
arch/i386/kernel/pci-pc.c +0 -0
 		pci_write_config_byte(d, where, v);
 	}

printk("Disabling VIA memory write queue: [%02x] %02x->%02x\n", where, v, v & 0x1f);

This way we will see exactly where and what changed --
vda

#7 lore raw

Re: [Patch] (was: Re: fixup descriptions in pci-pc.c)

In reply to Oliver Feiler
Quoted 10 lines · Oliver Feiler

Hello,

This just changes the printk in the via_northbridge_bug fixup to some
more meaningful output as it is already in 2.5.3. Please apply.

Oliver

arch/i386/kernel/pci-pc.c line 1135

Quoted 8 lines
arch/i386/kernel/pci-pc.c +1 -1
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling broken memory write queue.\n");
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}

Even more meaningful:

"Disabling VIA Northbridge broken memory write queue.\n"

Signature · 4 lines
____/|  Ragnar Højland      Freedom - Linux - OpenGL |    Brainbench MVP
\ o.O|  PGP94C4B2F0D27DE025BE2302C104B78C56 B72F0822 | for Unix Programming
 =(_)=  "Thou shalt not follow the NULL pointer for  | (www.brainbench.com)
   U     chaos and madness await thee at its end."      [56 pend. Jan  8]