Skip to contentSkip to conversation

Proper fix for sym53c8xx_2 driver and dma64_addr_t

Linux-ia64 Christoph Hellwig 3 participants 3 messages Feb 6, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines · David S. Miller

What driver wants to get at this type and what are they using it for? dma_addr_t should be used by every driver I am aware of except the clustering PCI cards I've been told about and that driver isn't in the kernel at this time.

So who needs it? :-)

The new sym53c8xx driver (sym2), and that one only if is actually is configured for DAC-mode (SYM_CONF_DMA_ADDRESSING_MODE > 0).

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.
#2 lore raw

From: Christoph Hellwig <[email protected]>
Date: Wed, 6 Feb 2002 09:35:58 +0100

Quoted 1 line · David S. Miller

So who needs it? :-)

The new sym53c8xx driver (sym2), and that one only if is actually is configured for DAC-mode (SYM_CONF_DMA_ADDRESSING_MODE > 0).

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

The sym2 driver needs to be fixed.

Franks a lot,
David S. Miller
[email protected]

#3 lore raw
Quoted 6 lines · David S. Miller

From: Christoph Hellwig <[email protected]>
Date: Wed, 6 Feb 2002 09:35:58 +0100

Quoted 1 line · David S. Miller

So who needs it? :-)

Quoted 7 lines

The new sym53c8xx driver (sym2), and that one only if is actually is configured for DAC-mode (SYM_CONF_DMA_ADDRESSING_MODE > 0).

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

The sym2 driver needs to be fixed.

The code written at 't' time was using what was available at that time. If you can let me know when Linux will be rewritten in Java, this will be useful for me to be ready in time. :-)

a.c renamed from sym_glue.c +0 -4
@@ -313,11 +313,7 @@
 #ifndef SYM_LINUX_DYNAMIC_DMA_MAPPING
 typedef u_long		bus_addr_t;
 #else
-#if	SYM_CONF_DMA_ADDRESSING_MODE > 0
-typedef dma64_addr_t	bus_addr_t;
-#else
 typedef dma_addr_t	bus_addr_t;
-#endif
 #endif
 

You may get a couple of warnings, but since I haven't hardware to check this, I am ready to apply patches.

Gérard.

PS:
The driver Java version is planned to be available on April the 1rst. ;)