Skip to contentSkip to conversation

Proper fix for sym53c8xx_2 driver and dma64_addr_t

Linux-ia64 Christoph Hellwig 4 participants 9 messages Feb 6, 2002 – Feb 7, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 3 lines · David Mosberger

Christoph> IA64 needs to define dma64_addr_t.

Not before the driver writers understand when to use it.

Architecture maintainers are not supposed to decide whether driver writers understand APIs. The dma64_addr_t type is part of the PCI DMA interface and IA64 needs to defines it.

Linus, could you please accept the below patch to define dma64_addr_t on IA64?

Christoph

Signature · 17 lines
Of course it doesn't work. We've performed a software upgrade.

Index: include/asm-ia64/types.h
===================================================================
RCS file: /vger/linux/include/asm-ia64/types.h,v
retrieving revision 1.3
diff -u -u -r1.3 types.h
--- include/asm-ia64/types.h	22 Apr 2000 00:45:18 -0000	1.3
+++ include/asm-ia64/types.h	6 Feb 2002 08:24:24 -0000
@@ -63,6 +63,7 @@
 /* DMA addresses are 64-bits wide, in general.  */
 
 typedef u64 dma_addr_t;
+typedef u64 dma64_addr_t;
 
 # endif /* __KERNEL__ */
 #endif /* !__ASSEMBLY__ */
#2 lore raw

From: Christoph Hellwig <[email protected]>
Date: Wed, 6 Feb 2002 09:21:29 +0100

Quoted 3 lines · David Mosberger

Christoph> IA64 needs to define dma64_addr_t.

Not before the driver writers understand when to use it.

Architecture maintainers are not supposed to decide whether driver writers understand APIs. The dma64_addr_t type is part of the PCI DMA interface and IA64 needs to defines it.

You do have a point, but so does David.

What driver wants to get at this type and what are they using it for? dma_addr_t should be used by every driver I am aware of except the clustering PCI cards I've been told about and that driver isn't in the kernel at this time.

So who needs it? :-)

#3 lore raw
In reply to Christoph Hellwig
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Christoph Hellwig

Christoph> On Tue, Feb 05, 2002 at 01:44:06PM -0800, David Mosberger Christoph> wrote: IA64 needs to define dma64_addr_t.

Quoted 1 line
Quoted 1 line

Not before the driver writers understand when to use it.

Christoph> Architecture maintainers are not supposed to decide Christoph> whether driver writers understand APIs. The dma64_addr_t Christoph> type is part of the PCI DMA interface and IA64 needs to Christoph> defines it.

Then find a better way to catch errant uses of dma64_addr_t. I have spent too much time discussing the DMA API with Dave M to see it being misused for no good reason. It will take some time until there are enough sample drivers that show proper usage of the DMA interface. There is almost no driver that needs dma64_addr_t. We can add it once there is an ia64 driver that *really* needs it.

Christoph> Linus, could you please accept the below patch to define Christoph> dma64_addr_t on IA64?

Christoph, if you want this type your linux distro, you can add it with your own patch. For the time being, I'm the ia64 linux maintainer so I hope you can respect my decisions.

	--david
#4 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · David S. Miller

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

When the sym2 driver is configured with SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and needs dma64_addr_t. It doesn't use it when using the default addressing mode.

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.
#5 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Christoph Hellwig

Christoph> On Wed, Feb 06, 2002 at 12:45:03AM -0800, David S. Miller

Quoted 2 lines · Christoph> wrote:
Quoted 2 lines

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

Christoph> When the sym2 driver is configured with Christoph> SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and Christoph> needs dma64_addr_t. It doesn't use it when using the Christoph> default addressing mode.

The driver never uses the pci_dac* interface, hence it should not use dma64_addr_t. If the driver needs a 64-bit wide type, u64 will do fine.

	--david
#6 lore raw
Quoted 7 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Christoph Hellwig

Christoph> On Wed, Feb 06, 2002 at 12:45:03AM -0800, David S. Miller

Quoted 2 lines · Christoph> wrote:
Quoted 2 lines

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

Quoted 8 lines

Christoph> When the sym2 driver is configured with Christoph> SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and Christoph> needs dma64_addr_t. It doesn't use it when using the Christoph> default addressing mode.

The driver never uses the pci_dac* interface, hence it should not use dma64_addr_t. If the driver needs a 64-bit wide type, u64 will do fine.

The driver was ready for PCI DAC months before the Linux way to do DAC was stabilized to the current one. Given the discussion on the harmless way the sym2 driver is using dma64_addr_t, it seems to me that this interface may still move.

This let me think that the real problem is not the sym2 driver here, but rather the Linux IO interfaces saga that lasts from years.

For now just replacing all occurrences (in fact only 1) of the offending dma64 thing in sym_glue.c by the corresponding dma thing should do the trick and close this thread as a result.

If you want to discuss about either PCI DAC under Linux or Linux-i64 arch (that btw seems to be dead prior to have born) then, please, change the subject of this thread.

Gérard.

#7 lore raw
In reply to Christoph Hellwig

From: Christoph Hellwig <[email protected]>
Date: Wed, 6 Feb 2002 18:10:42 +0100

When the sym2 driver is configured with SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and needs dma64_addr_t. It doesn't use it when using the default addressing mode.

NO it damn well does not! If the platform is NEVER GOING TO GIVE the driver a 64-bit address (because, for example, it has IOMMU hardware), dma_addr_t need only be 32-bits and that it how it is declared on several platforms.

Please read the DMA API documentation.

dma64_addr_t is _ONLY_, I REPEAT _ONLY_ to be used when the driver is making use of the following routines for it's DMA usage:

pci_dac_page_to_dma
pci_dac_dma_to_page
pci_dac_dma_to_offset
pci_dac_dma_sync_single

And NO SCSI OR NET driver should ever use these routines.

In fact, no driver in the tree right now should be using this. The only known example that needs those interfaces are clustering cards. And thats it!

Everything in the tree right now should use only pci_map_single and friends, and it should set the device DMA mask bits properly to indicate DAC capability. Do you see any pci_map_single, pci_map_sg, etc. implementation working with dma64_addr_t arguments? If so, thats a huge bug and it must be fixed.

#8 lore raw
Quoted 28 lines · David S. Miller

From: Christoph Hellwig <[email protected]>
Date: Wed, 6 Feb 2002 18:10:42 +0100

When the sym2 driver is configured with SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and needs dma64_addr_t. It doesn't use it when using the default addressing mode.

NO it damn well does not! If the platform is NEVER GOING TO GIVE the driver a 64-bit address (because, for example, it has IOMMU hardware), dma_addr_t need only be 32-bits and that it how it is declared on several platforms.

Please read the DMA API documentation.

dma64_addr_t is _ONLY_, I REPEAT _ONLY_ to be used when the driver is making use of the following routines for it's DMA usage:

pci_dac_page_to_dma
pci_dac_dma_to_page
pci_dac_dma_to_offset
pci_dac_dma_sync_single

And NO SCSI OR NET driver should ever use these routines.

In fact, no driver in the tree right now should be using this. The only known example that needs those interfaces are clustering cards. And thats it!

Quoted 5 lines

Everything in the tree right now should use only pci_map_single and friends, and it should set the device DMA mask bits properly to indicate DAC capability. Do you see any pci_map_single, pci_map_sg, etc. implementation working with dma64_addr_t arguments? If so, thats a huge bug and it must be fixed.

You should calm down, in my opinion. All the burden about the PCI dma API is your fault to you David and you David. :)
It takes a too long time for you 2 Davids to agree about this API.

Personnally, I donnot care about dma64_addr_t versus dma_addr_t being 32, 64 even 69 bits (why not, some machine with 36 bit addressing are still in use).

Just change the topic, please. The sym2 driver has nothing to do with this boring thread.

Gérard.

#9 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · David S. Miller

It is not using the DMA apis correctly then, it should be using dma_addr_t which may or may not be 64-bits on a given platform.

When the sym2 driver is configured with SYM_CONF_DMA_ADDRESSING_MOD > 1 it uses DAC accessing and needs dma64_addr_t. It doesn't use it when using the default addressing mode.

Sorry, it doesn't use the _dac_ APIs. Still I'm the opinion that either architecture should support dma64_addr_t or we need a HAVE_PCI_DAC_API define.

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.