Fix export of simple_strtol
Hi,
It appears that we have a certain amount of randomness about which symbols are exported where. (Maybe someone should feed this into /dev/random ?) 8)
Both simple_strtoul and simple_strtol appear in linux/lib/vsprintf.c yet we have simple_strtoul exported by kernel/ksyms.c, and simple_strtol exported by some architecture specific ksyms.c files.
The following patch rectifies this by exporting simple_strtol in kernel/ksyms.c and removing it from the machine specific files.
[Georg Nikodym pointed this out and sent an initial patch to add
it to the main kernel ksyms file, I fixed up the architecture specific files].
arch/cris/kernel/ksyms.c +0 -1
@@ -36,7 +36,6 @@EXPORT_SYMBOL (strtok);EXPORT_SYMBOL (strpbrk); -EXPORT_SYMBOL (simple_strtol);EXPORT_SYMBOL (strstr);EXPORT_SYMBOL (strchr);
arch/i386/kernel/i386_ksyms.c +0 -1
@@ -93,7 +93,6 @@EXPORT_SYMBOL (strtok);EXPORT_SYMBOL (strpbrk); -EXPORT_SYMBOL (simple_strtol);EXPORT_SYMBOL (strstr);EXPORT_SYMBOL (strncpy_from_user);
arch/mips/kernel/mips_ksyms.c +0 -1
@@ -51,7 +51,6 @@EXPORT_SYMBOL_NOVERS (memset);EXPORT_SYMBOL_NOVERS (memcpy);EXPORT_SYMBOL_NOVERS (memmove); -EXPORT_SYMBOL (simple_strtol);EXPORT_SYMBOL_NOVERS (strcat);EXPORT_SYMBOL_NOVERS (strchr);EXPORT_SYMBOL_NOVERS (strlen);
arch/mips64/kernel/mips64_ksyms.c +0 -1
@@ -48,7 +48,6 @@EXPORT_SYMBOL_NOVERS (memset);EXPORT_SYMBOL_NOVERS (memcpy);EXPORT_SYMBOL_NOVERS (memmove); -EXPORT_SYMBOL (simple_strtol);EXPORT_SYMBOL_NOVERS (strcat);EXPORT_SYMBOL_NOVERS (strchr);EXPORT_SYMBOL_NOVERS (strlen);
arch/sh/kernel/sh_ksyms.c +0 -2
@@ -39,8 +39,6 @@/* Networking helper routines. */ EXPORT_SYMBOL (csum_partial_copy); -EXPORT_SYMBOL (simple_strtol); -EXPORT_SYMBOL (strtok);EXPORT_SYMBOL (strpbrk);EXPORT_SYMBOL (strstr);
kernel/ksyms.c +1 -0
@@ -470,6 +470,7 @@EXPORT_SYMBOL (bdevname);EXPORT_SYMBOL (cdevname);EXPORT_SYMBOL (simple_strtoul); +EXPORT_SYMBOL (simple_strtol);EXPORT_SYMBOL (system_utsname);/* UTS data */ EXPORT_SYMBOL (uts_sem);/* UTS semaphore */ #ifndef __mips__
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html