Linux 2.4.18-pre9
Quoted 6 lines
Jeff Garzik wrote:
Quoted 2 lines · Simon Turvey
Quoted 1 line
Can you tell me if the final 2.4.18 will solve the problems with recent
binutils? Or is the onus on the binutils maintainer to fix this?
What driver are you having problems with?
how about bttv and usb-uhci, both of which I've sent patches for multiple times.
Quoted 5 lines
Typically this problem is solved by a one-line fix to a specific driver, in 2.4.x.
Jeff
drivers/media/video/bttv-driver.c +11 -4
@@ -2820,11 +2820,10 @@* Scan for a Bt848 card, request the irq and map the io memory */ -static void __devexit bttv_remove(struct pci_dev *pci_dev) +static void bttv_remove_card (struct bttv *btv) {u8 command;int j; -struct bttv *btv =pci_get_drvdata (pci_dev);if (bttv_verbose)printk ("bttv%d: unloading\n" ,btv->nr);
@@ -2890,10 +2889,18 @@ btv->shutdown=1 ;wake_up (&btv->gpioq); -pci_set_drvdata (pci_dev,NULL );return ; } +static void __devexit bttv_remove(struct pci_dev *pci_dev) +{ +struct bttv *btv =pci_get_drvdata (pci_dev); + +if (btv) { +bttv_remove_card (btv); +pci_set_drvdata (pci_dev,NULL ); + } +}static int __devinit bttv_probe (struct pci_dev *dev,const struct pci_device_id *pci_id) {
@@ -2992,7 +2999,7 @@pci_set_drvdata (dev,btv);if (init_bt848 (btv) <0 ) { -bttv_remove (dev); +bttv_remove_card (btv);return -EIO ; } bttv_num++;
drivers/usb/usb-uhci.c +15 -5
@@ -2845,10 +2845,9 @@ s->running =1 ; } -_static void __devexit -uhci_pci_remove (struct pci_dev *dev) +_static void +uhci_pci_remove_card (uhci_t *s) { -uhci_t *s =pci_get_drvdata (dev);struct usb_device *root_hub = s->bus->root_hub; s->running =0 ;// Don't allow submit_urb
@@ -2868,7 +2867,17 @@free_irq (s->irq, s);usb_free_bus (s->bus);cleanup_skel (s); -kfree (s); +} + +_static void __devexit +uhci_pci_remove (struct pci_dev *dev) +{ +uhci_t *s =pci_get_drvdata (dev); + +if (s) { +uhci_pci_remove_card (s); +kfree (s); + } } _static int __init uhci_start_usb (uhci_t *s)
@@ -3001,7 +3010,8 @@ s->irq = irq;if (uhci_start_usb (s) <0 ) { -uhci_pci_remove (dev); +uhci_pci_remove_card (s); +kfree (s);return -1 ; }
Quoted 2 lines · Jason Thomas
how about bttv and usb-uhci, both of which I've sent patches for multiple times.
usb-uhci has been fixed. Let me know if you still have problems with 2.4.18-pre9.
thanks,
greg k-h