Skip to contentSkip to conversation

Linux-2.5.4-pre6 uhci.c compile fix

PATCH In review Udo A. Steinberg 2 participants 2 messages Feb 11, 2002 USB

lore
Share & tools
lore

Udo A. Steinberg

author
#0 lore raw

PATCH 1/1 Linux-2.5.4-pre6 uhci.c compile fix

Hi Linus, Greg,

The attached patch fixes a trivial compiler warning in uhci.c:

uhci.c: In function `uhci_unlink_generic':
uhci.c:1694: warning: suggest parentheses around && within ||

Regards,
Udo.

drivers/usb/uhci.c Mon Feb 11 03:11:47 2002 renamed from drivers/usb/uhci.c Mon Feb 11 03:04:17 2002 +2 -2
diff -X dontdiff -Naur linux-2.5.4-pre-vanilla/drivers/usb/uhci.c linux-2.5.4-pre/drivers/usb/uhci.c
@@ -1689,8 +1689,8 @@
 
                /* Control and Isochronous ignore the toggle, so this */
                /* is safe for all types */
-               if ((!(td->status & TD_CTRL_ACTIVE) &&
-                   (uhci_actual_length(td->status) < uhci_expected_length(td->info)) ||
+               if (((!(td->status & TD_CTRL_ACTIVE) &&
+                   (uhci_actual_length(td->status) < uhci_expected_length(td->info))) ||
                    tmp == head)) {
                        usb_settoggle(urb->dev, uhci_endpoint(td->info),
                                uhci_packetout(td->info),
#1 lore raw
Quoted 4 lines · Udo A. Steinberg

Hi Linus, Greg,

The attached patch fixes a trivial compiler warning in uhci.c:

I've asked Johannes about this warning, and he said he'd fix it, so I'd prefer you to send your patch to him first.

thanks,

greg k-h